C# 为什么我的模拟列表没有删除某个元素?
对于我的一个作业,我必须使用IRepository作为基础,创建一个从数据库返回下一项的方法。我正在使用TDD设计周期,到目前为止,这是我所拥有的:C# 为什么我的模拟列表没有删除某个元素?,c#,linq,moq,C#,Linq,Moq,对于我的一个作业,我必须使用IRepository作为基础,创建一个从数据库返回下一项的方法。我正在使用TDD设计周期,到目前为止,这是我所拥有的: [TestMethod] public void ShouldReturnNextExportRequest() { var requests = new List<ExportRequest>(); for (var i = 0; i < 100; i++)
[TestMethod]
public void ShouldReturnNextExportRequest()
{
var requests = new List<ExportRequest>();
for (var i = 0; i < 100; i++)
{
var exportRequest = new Mock<ExportRequest>();
exportRequest.SetupGet(req => req.Id).Returns(i);
requests.Add(exportRequest.Object);
}
// Over-writing variables is bad
requests = requests.OrderBy(er => er.Id).ToList();
/**
* Mock the IRepository so that the Min() call returns the export request with the minimum Id
*/
var repo = new Mock<IRepository<ExportRequest>>();
repo.Setup(rep => rep.Min(It.IsAny<Expression<Func<ExportRequest, int>>>()))
.Returns<Expression<Func<ExportRequest, int>>>(expr => requests.Min(e => e.Id));
repo.Setup(rep => rep.Get(It.IsAny<int>())).Returns<int>(requests.ElementAt);
repo.Setup(rep => rep.Delete(It.IsAny<ExportRequest>()))
.Callback<ExportRequest>(req => Assert.IsTrue(requests.Remove(req), "Couldn't remove {0} from list", req.Id));
var exportRequestRepository = new ExportRequestRepository(repo.Object);
exportRequestRepository.GetNextRequest();
exportRequestRepository.GetNextRequest();
var third = exportRequestRepository.GetNextRequest();
var top = requests.First();
Assert.AreEqual(top.Id, third.Id, "Top element in list has id of {0}, but return from repository is {1}", top.Id, third.Id);
}
这一切都很好,但是第二个元素(id为1)从未从列表中删除。我已经计算出这取决于List
上的IEnumerable.Min
实现,因为它似乎从未返回Id为1的元素(通过在调试模式下查看列表确定)
我错过了什么明显的东西吗
注:
我正在使用SharpRepository中的模拟IRepository。这并不是说它有什么区别,因为Moq-ed接口没有固有的动作,但值得注意
编辑:测试输出
Test Name: ShouldReturnNextExportRequest
Test FullName: ExportService.Tests.ExportRequestRepositorySpecification.ShouldReturnNextExportRequest
Test Source: c:\Users\dan.pantry\Desktop\RUMM\ExportService.Tests\ExportRequestRepositorySpecification.cs : line 17
Test Outcome: Failed
Test Duration: 0:00:00.211873
Result Message: Assert.AreEqual failed. Expected:<1>. Actual:<3>. Top element in list has id of 1, but return from repository is 3
Result StackTrace: at ExportService.Tests.ExportRequestRepositorySpecification.ShouldReturnNextExportRequest() in c:\Users\dan.pantry\Desktop\RUMM\ExportService.Tests\ExportRequestRepositorySpecification.cs:line 49
EDIT3:这是GetNextRequest()
中的_exportRequestRepository的来源-在测试中,它是模拟存储库,并被注入构造函数
public ExportRequestRepository(IRepository<ExportRequest> exportRequestRepository)
{
_exportRequestRepository = exportRequestRepository;
}
公共ExportRequestRepository(IRepository ExportRequestRepository)
{
_exportRequestRepository=exportRequestRepository;
}
问题已解决。
问题是,当我应该使用Find
时,我正在使用ElementAt
,而我在GetNextRequest()
之前调用了First()
(获取下一个请求“pops”底层存储库中的元素,但这可能会改变)
var repo=new Mock();
repo.Setup(rep=>rep.Min(It.IsAny()))
.Returns(expr=>requests.Min(e=>e.Id));
repo.Setup(rep=>rep.Get(It.IsAny())。返回(i=>requests.Find(er=>er.Id==i));
repo.Setup(rep=>rep.Delete(It.IsAny()))
.Callback(req=>Assert.IsTrue(requests.Remove(req),“无法从列表中删除{0}”,req.Id));
var exportRequestRepository=新的exportRequestRepository(repo.Object);
AreEqual(0,exportRequestRepository.GetNextRequest().Id);
AreEqual(1,exportRequestRepository.GetNextRequest().Id);
var top=requests.First();
var third=exportRequestRepository.GetNextRequest();
AreEqual(top.Id,third.Id,“列表中的top元素的Id为{0},但从存储库返回的是{1}”,top.Id,third.Id);
解决的代码如上所述。如您所见,
Get
现在使用requests.Find()
而不是requests.ElementAt
exportRequestRepository在哪里定义?我假设这是在安装方法中使用的?在测试中,您指的是本地exportRequestRepository,但在GetNextRequest中,您使用的是\u exportRequestRepository?抱歉,我理解这些名称令人困惑_exportRequestRepository是注入exportRequestRepository构造函数的存储库。基本上,_exportRequestRepository是注入我的更具体的存储库exportRequestRepository中的模拟SharpRepository IRepository。
repo.Setup(rep => rep.Get(It.IsAny<int>())).Returns<int>(requests.ElementAt)
.Callback<int>(req => Console.WriteLine("Retrieved {0}", req));
Retrieved 0
Retrieved 1
Retrieved 1
public ExportRequestRepository(IRepository<ExportRequest> exportRequestRepository)
{
_exportRequestRepository = exportRequestRepository;
}
var repo = new Mock<IRepository<ExportRequest>>();
repo.Setup(rep => rep.Min(It.IsAny<Expression<Func<ExportRequest, int>>>()))
.Returns<Expression<Func<ExportRequest, int>>>(expr => requests.Min(e => e.Id));
repo.Setup(rep => rep.Get(It.IsAny<int>())).Returns<int>(i => requests.Find(er => er.Id == i));
repo.Setup(rep => rep.Delete(It.IsAny<ExportRequest>()))
.Callback<ExportRequest>(req => Assert.IsTrue(requests.Remove(req), "Couldn't remove {0} from list", req.Id));
var exportRequestRepository = new ExportRequestRepository(repo.Object);
Assert.AreEqual(0, exportRequestRepository.GetNextRequest().Id);
Assert.AreEqual(1, exportRequestRepository.GetNextRequest().Id);
var top = requests.First();
var third = exportRequestRepository.GetNextRequest();
Assert.AreEqual(top.Id, third.Id, "Top element in list has id of {0}, but return from repository is {1}", top.Id, third.Id);