Spring boot Spring boot JPA和事务性:无法通过单元测试重现错误

Spring boot Spring boot JPA和事务性:无法通过单元测试重现错误,spring-boot,jpa,spring-transactions,transactional,Spring Boot,Jpa,Spring Transactions,Transactional,我们有一种方法,可以添加新记录(信用卡)并更新现有记录。更具体地说,我们将现有的信用卡设置为禁用,并添加一个新的,创建为活动的信用卡 @Service @Transactional public class CreditCardServiceImpl { @Override public CreditCard saveCard(Map<String, String> data, String cardType, String token, HashMap<String, St

我们有一种方法,可以添加新记录(信用卡)并更新现有记录。更具体地说,我们将现有的信用卡设置为禁用,并添加一个新的,创建为活动的信用卡

@Service
@Transactional
public class CreditCardServiceImpl {

@Override
public CreditCard saveCard(Map<String, String> data, String cardType, String token, HashMap<String, String> card, String entityId, String fleetId, PspSettings pspSetting)
        throws ParseException, ClientProtocolException, IOException, AdyenUnAuthorizedException, org.json.simple.parser.ParseException, AdyenException {

    LOG.info("Check if creditCard  exists for entityId#{}", entityId);
    CreditCard creditCard = creditCardRepository.findByEntityIdAndStatus(entityId, CreditCardStatus.ACTIVE);
    if (creditCard == null) {
        creditCard = createCreditCard(data, cardType, token, card, entityId, fleetId);

    } else {
        LOG.info("Credit card#{} found, disable it and create a new one", creditCard.getId());
        // disable the older card for this entity
        creditCard.setStatus(CreditCardStatus.DISABLED);
        creditCardRepository.save(creditCard);
        // create a new card for this entity
        creditCard = createCreditCard(data, cardType, token, card, entityId, fleetId);  
// ***** SMELLLY ***

    }

    return creditCard;
}
我们有一个bug,在DB中有两张相同的信用卡,都设置为活动的

我怀疑这是因为我们重复使用了本地信用卡变量(见上面的***臭**行)

所以我认为这可以很容易地通过使用另一个本地var而不是信用卡来解决

令人不安的问题是,我无法在单元测试中重现这一点

以下测试通过

@Test
    public void disableAdyenTokenTest()  {

        //save a card first and then check that it exists to disable it
        EntityX entityX = new EntityX();
        // some stuff   
        entityX.setFleetId(BASE_FLEET);       
        entityX = entityService.save(entityX);
        LOG.info("----- save credit card for test -----");

        creditCardService.save(cc);

        Map<String, String> data = new HashMap<String, String>();
        String cardType="visa";
        String newToken="0000000022";
        HashMap card = new HashMap<String, String>();
        Date date =  new Date();
        SimpleDateFormat formater = new SimpleDateFormat("mm/yyyy");
        String dateString = formater.format(date);
        data.put("expiryDate", dateString);
        data.put("cardSummary", "cardSummary");
        card.put("holderName", "Joe Louis");

        CreditCard ccReturned = creditCardService.saveCard(data, cardType, newToken, card, entityX.getId(), BASE_FLEET, settings);
        assertNotNull(ccReturned);
        assertEquals(CreditCardStatus.ACTIVE, ccReturned.getStatus());
        CreditCard activeCard = creditCardService.findByEntityIdAndStatus(entityX.getId(), CreditCardStatus.ACTIVE);
        assertNotNull(activeCard);

        CreditCard disabledCard = creditCardService.findByEntityIdAndStatus(entityX.getId(), CreditCardStatus.DISABLED);
        assertNotNull(disabledCard);
        List<PspTransaction> list = pspTransactionRepo.findAll();
        assertNotNull(list);
    }

更新


应用程序使用MariaDB数据库运行,而单元测试在内存数据库中的H2上运行。这就是原因吗?

信用卡实体是什么样子的?PK/@Id是什么?@EssexBoy更新我还没有发现问题,但您应该使用save的返回值进行进一步操作:
@Test
    public void disableAdyenTokenTest()  {

        //save a card first and then check that it exists to disable it
        EntityX entityX = new EntityX();
        // some stuff   
        entityX.setFleetId(BASE_FLEET);       
        entityX = entityService.save(entityX);
        LOG.info("----- save credit card for test -----");

        creditCardService.save(cc);

        Map<String, String> data = new HashMap<String, String>();
        String cardType="visa";
        String newToken="0000000022";
        HashMap card = new HashMap<String, String>();
        Date date =  new Date();
        SimpleDateFormat formater = new SimpleDateFormat("mm/yyyy");
        String dateString = formater.format(date);
        data.put("expiryDate", dateString);
        data.put("cardSummary", "cardSummary");
        card.put("holderName", "Joe Louis");

        CreditCard ccReturned = creditCardService.saveCard(data, cardType, newToken, card, entityX.getId(), BASE_FLEET, settings);
        assertNotNull(ccReturned);
        assertEquals(CreditCardStatus.ACTIVE, ccReturned.getStatus());
        CreditCard activeCard = creditCardService.findByEntityIdAndStatus(entityX.getId(), CreditCardStatus.ACTIVE);
        assertNotNull(activeCard);

        CreditCard disabledCard = creditCardService.findByEntityIdAndStatus(entityX.getId(), CreditCardStatus.DISABLED);
        assertNotNull(disabledCard);
        List<PspTransaction> list = pspTransactionRepo.findAll();
        assertNotNull(list);
    }
@Entity
@Cache(usage = CacheConcurrencyStrategy.NONSTRICT_READ_WRITE)
public class CreditCard implements Serializable {
    /** The Constant serialVersionUID. */
    private static final long serialVersionUID = 1L;

    /** The id. */
    @Id
    @GeneratedValue(strategy = GenerationType.IDENTITY)
    private Long id;