C# 传递Ninject内核是一种好的实践吗?
我正在编写一个小框架,它执行了几个任务。 有些任务需要通过Ninject注入的特定属性C# 传递Ninject内核是一种好的实践吗?,c#,ninject,C#,Ninject,我正在编写一个小框架,它执行了几个任务。 有些任务需要通过Ninject注入的特定属性 var schedulerInstance = kernel.Get<Scheduler>(); 假设我的基类中有以下表示单个任务的构造函数: protected DDPSchedulerTask(ILogger logger, List<string> platforms, IBackOfficeDataStore backOfficeDataStore, ICommonDataS
var schedulerInstance = kernel.Get<Scheduler>();
假设我的基类中有以下表示单个任务的构造函数:
protected DDPSchedulerTask(ILogger logger, List<string> platforms, IBackOfficeDataStore backOfficeDataStore, ICommonDataStore commonDataStore)
{
_logger = logger;
_platforms = platforms;
_backOfficeDataStore = backOfficeDataStore;
_commonDataStore = commonDataStore;
}
有人知道如何解决这个问题吗
我可以将内核传递给不同的任务,但是有些东西告诉我这不是正确的方法
亲切问候在这种情况下,我通常使用工厂模式。在调度程序中,可以将任务工厂作为依赖项。此工厂还可以有多种方法来创建不同类型的任务
class DDPSchedulerTaskFactory : IDDPSchedulerTaskFactory
{
DDPSchedulerTaskFactory(ILogger logger, List<string> platforms, IBackOfficeDataStore backOfficeDataStore, ICommonDataStore commonDataStore)
{
_logger = logger;
_platforms = platforms;
_backOfficeDataStore = backOfficeDataStore;
_commonDataStore = commonDataStore;
}
public IDDPSchedulerTask CreateNormal(){
return new DDPSchedulerTask(
_logger,
_platforms,
_backOfficeDataStore,
_commonDataStore);
}
public IDDPSchedulerTask CreateSpecial(someAdditionalParameter){
return new AnotherDDPSchedulerTask(
_logger,
_platforms,
_backOfficeDataStore,
_commonDataStore,
someAdditionalParameter);
}
public IDDPSchedulerTask CreateTaskWithDifferentDependenties(yetAnotherParameter){
return new AnotherDDPSchedulerTask(
_logger,
_platforms,
yetAnotherParameter);
}
}
你应该利用这个机会 只需创建一个代表任务工厂的接口。然后将信息传递给Ninject,这是一个工厂,他将为您创建此接口的完整实现
using System;
using System.Collections.Generic;
using Ninject;
using Ninject.Extensions.Factory;
internal class Program
{
public static void Main(string[] args)
{
IKernel ninjectKernel = new StandardKernel();
ninjectKernel.Bind<DDPSchedulerTask>().ToSelf();
ninjectKernel.Bind<AWNFileGeneratorTask>().ToSelf();
ninjectKernel.Bind<IDirectoryResolver>().To<DirectoryResolver>();
ninjectKernel.Bind<ITaskFactory>().ToFactory();
var mainTask = ninjectKernel.Get<DDPSchedulerTask>();
mainTask.CreateDbSchedulerTask();
mainTask.CreateAwnFileTask();
Console.ReadLine();
}
}
public interface ITaskFactory
{
TTask CreateTask<TTask>() where TTask : DDPSchedulerTask;
}
public class DDPSchedulerTask
{
private readonly ITaskFactory _tasksFactory;
private readonly List<DDPSchedulerTask> _tasksList;
public DDPSchedulerTask(ITaskFactory tasksFactory)
{
_tasksFactory = tasksFactory;
_tasksList = new List<DDPSchedulerTask>();
}
public void CreateAwnFileTask()
{
var task = _tasksFactory.CreateTask<AWNFileGeneratorTask>();
_tasksList.Add(task);
}
public void CreateDbSchedulerTask()
{
var task = _tasksFactory.CreateTask<DDPSchedulerTask>();
_tasksList.Add(task);
}
}
public class AWNFileGeneratorTask : DDPSchedulerTask
{
[Inject]
public IDirectoryResolver DirectoryResolver { get; set; }
public AWNFileGeneratorTask(ITaskFactory tasksFactory)
: base(tasksFactory)
{
}
}
public interface IDirectoryResolver
{
}
public class DirectoryResolver : IDirectoryResolver
{
}
额外参数注入:
public interface ITaskFactory
{
DDPSchedulerTask CreateDDPSchedulerTask();
AWNFileGeneratorTask CreateAWNFileGeneratorTask(string extraParam);
}
public class AWNFileGeneratorTask : DDPSchedulerTask
{
private IDirectoryResolver _directoryResolver;
private string _extraParam;
public AWNFileGeneratorTask(ITaskFactory tasksFactory, IDirectoryResolver directoryResolver,
string extraParam)
: base(tasksFactory)
{
_extraParam = extraParam;
_directoryResolver = directoryResolver;
}
}
public void CreateAwnFileTask()
{
var task = _tasksFactory.CreateAWNFileGeneratorTask("extra");
_tasksList.Add(task);
}
好的,但是代码中有些地方不正确。在create方法中,返回类型设置为
DDPSchedulerTask
,但返回的是DDPSchedulerTaskFactory
。另外,你能再解释一下你的解决方案吗?我应该从哪里调用create方法,因为我希望Unity也能注入额外的属性。谢谢你的更正。你介意告诉我从哪里我需要调用这个工厂,因为我想继续使用Ninject来确保依赖注入。我看不出这里有胶水。我仍然需要传入someAdditionalParameters
,我希望Ninject内核在其中解决此问题。@复杂性您希望计划程序添加/配置所有任务,还是希望从外部调用计划程序上的某个AddTask()方法?计划程序本身正在管理任务的创建,而不是从外部。如果是从外面来的。但问题是调度器可以定义例如5个任务,其中每个任务有4个参数,这些参数通过依赖项注入自动解决,因为这些属性被注入调度器的构造函数中。但是假设这5个任务中的每一个都需要另一个属性,我不想在调度器的构造函数中添加所有这些属性。相反,我希望调度器解决任务的依赖关系。那么内核共享呢?@复杂性我想,你说的是服务定位器,它被称为任何模式。理想情况下,您希望只在一个地方使用内核—某些入口点。并让它进一步传播依赖关系。请参阅编辑。这样您就可以绑定到Ninject-无法轻松替换IOC容器。(谈论注入属性)构造函数注入IDirectoryResolver没有问题。它也应该起作用。例如:public AWNFileGeneratorTask(ITaskFactory tasksFactory,IDirectoryResolver directorySolver):base(tasksFactory)Ok。如何将附加参数(而不是依赖项)传递给任务构造函数?ITaskFactory的实现在哪里?没有ITaskFactory的实现。Ninject将自动实现此工厂。
class DDPSchedulerTaskFactory : IDDPSchedulerTaskFactory
{
DDPSchedulerTaskFactory(ILogger logger, List<string> platforms, IBackOfficeDataStore backOfficeDataStore, ICommonDataStore commonDataStore)
{
_logger = logger;
_platforms = platforms;
_backOfficeDataStore = backOfficeDataStore;
_commonDataStore = commonDataStore;
}
public IDDPSchedulerTask CreateNormal(){
return new DDPSchedulerTask(
_logger,
_platforms,
_backOfficeDataStore,
_commonDataStore);
}
public IDDPSchedulerTask CreateSpecial(someAdditionalParameter){
return new AnotherDDPSchedulerTask(
_logger,
_platforms,
_backOfficeDataStore,
_commonDataStore,
someAdditionalParameter);
}
public IDDPSchedulerTask CreateTaskWithDifferentDependenties(yetAnotherParameter){
return new AnotherDDPSchedulerTask(
_logger,
_platforms,
yetAnotherParameter);
}
}
class Scheduler{
IDDPSchedulerTaskFactory _taskFactory;
public Scheduler(IDDPSchedulerTaskFactory taskFactory){
_taskFactory = taskFactory; // factory gets all the needed dependencies for all tasks from DI
}
...
public void ConfigureTasks(){
_tasks.Add(_taskFactory.CreateNormal());
_tasks.Add(_taskFactory.CreateSpecial("Some important message"));
_tasks.Add(_taskFactory.CreateTaskWithDifferentDependenties(123));
}
}
using System;
using System.Collections.Generic;
using Ninject;
using Ninject.Extensions.Factory;
internal class Program
{
public static void Main(string[] args)
{
IKernel ninjectKernel = new StandardKernel();
ninjectKernel.Bind<DDPSchedulerTask>().ToSelf();
ninjectKernel.Bind<AWNFileGeneratorTask>().ToSelf();
ninjectKernel.Bind<IDirectoryResolver>().To<DirectoryResolver>();
ninjectKernel.Bind<ITaskFactory>().ToFactory();
var mainTask = ninjectKernel.Get<DDPSchedulerTask>();
mainTask.CreateDbSchedulerTask();
mainTask.CreateAwnFileTask();
Console.ReadLine();
}
}
public interface ITaskFactory
{
TTask CreateTask<TTask>() where TTask : DDPSchedulerTask;
}
public class DDPSchedulerTask
{
private readonly ITaskFactory _tasksFactory;
private readonly List<DDPSchedulerTask> _tasksList;
public DDPSchedulerTask(ITaskFactory tasksFactory)
{
_tasksFactory = tasksFactory;
_tasksList = new List<DDPSchedulerTask>();
}
public void CreateAwnFileTask()
{
var task = _tasksFactory.CreateTask<AWNFileGeneratorTask>();
_tasksList.Add(task);
}
public void CreateDbSchedulerTask()
{
var task = _tasksFactory.CreateTask<DDPSchedulerTask>();
_tasksList.Add(task);
}
}
public class AWNFileGeneratorTask : DDPSchedulerTask
{
[Inject]
public IDirectoryResolver DirectoryResolver { get; set; }
public AWNFileGeneratorTask(ITaskFactory tasksFactory)
: base(tasksFactory)
{
}
}
public interface IDirectoryResolver
{
}
public class DirectoryResolver : IDirectoryResolver
{
}
public class AWNFileGeneratorTask : DDPSchedulerTask
{
private IDirectoryResolver _directoryResolver;
public AWNFileGeneratorTask(ITaskFactory tasksFactory, IDirectoryResolver directoryResolver)
: base(tasksFactory)
{
_directoryResolver = directoryResolver;
}
}
public interface ITaskFactory
{
DDPSchedulerTask CreateDDPSchedulerTask();
AWNFileGeneratorTask CreateAWNFileGeneratorTask(string extraParam);
}
public class AWNFileGeneratorTask : DDPSchedulerTask
{
private IDirectoryResolver _directoryResolver;
private string _extraParam;
public AWNFileGeneratorTask(ITaskFactory tasksFactory, IDirectoryResolver directoryResolver,
string extraParam)
: base(tasksFactory)
{
_extraParam = extraParam;
_directoryResolver = directoryResolver;
}
}
public void CreateAwnFileTask()
{
var task = _tasksFactory.CreateAWNFileGeneratorTask("extra");
_tasksList.Add(task);
}