在x264中正确使用'nalu_process'回调
我希望利用libx264的低延迟编码机制,即在单个NAL单元可用时调用用户提供的回调,而不必等待整个帧编码后再开始处理 x264文档说明了该设施的以下内容:在x264中正确使用'nalu_process'回调,c,callback,segmentation-fault,libx264,C,Callback,Segmentation Fault,Libx264,我希望利用libx264的低延迟编码机制,即在单个NAL单元可用时调用用户提供的回调,而不必等待整个帧编码后再开始处理 x264文档说明了该设施的以下内容: /* Optional low-level callback for low-latency encoding. Called for each output NAL unit * immediately after the NAL unit is finished encoding. This allows the calling
/* Optional low-level callback for low-latency encoding. Called for each output NAL unit
* immediately after the NAL unit is finished encoding. This allows the calling application
* to begin processing video data (e.g. by sending packets over a network) before the frame
* is done encoding.
*
* This callback MUST do the following in order to work correctly:
* 1) Have available an output buffer of at least size nal->i_payload*3/2 + 5 + 64.
* 2) Call x264_nal_encode( h, dst, nal ), where dst is the output buffer.
* After these steps, the content of nal is valid and can be used in the same way as if
* the NAL unit were output by x264_encoder_encode.
*
* This does not need to be synchronous with the encoding process: the data pointed to
* by nal (both before and after x264_nal_encode) will remain valid until the next
* x264_encoder_encode call. The callback must be re-entrant.
*
* This callback does not work with frame-based threads; threads must be disabled
* or sliced-threads enabled. This callback also does not work as one would expect
* with HRD -- since the buffering period SEI cannot be calculated until the frame
* is finished encoding, it will not be sent via this callback.
*
* Note also that the NALs are not necessarily returned in order when sliced threads is
* enabled. Accordingly, the variable i_first_mb and i_last_mb are available in
* x264_nal_t to help the calling application reorder the slices if necessary.
*
* When this callback is enabled, x264_encoder_encode does not return valid NALs;
* the calling application is expected to acquire all output NALs through the callback.
*
* It is generally sensible to combine this callback with a use of slice-max-mbs or
* slice-max-size.
*
* The opaque pointer is the opaque pointer from the input frame associated with this
* NAL unit. This helps distinguish between nalu_process calls from different sources,
* e.g. if doing multiple encodes in one process.
*/
void (*nalu_process)( x264_t *h, x264_nal_t *nal, void *opaque );
这似乎很直截了当。然而,当我运行下面的伪代码时,我在标记行上得到一个segfault。我曾尝试在x264\u nal\u encode
本身中添加一些调试,以了解它在哪里出错,但似乎是函数调用本身导致了segfault。我是不是遗漏了什么?(让我们忽略一个事实,assert
的使用可能会使cb
不可重入–它只是向读者表明我的工作区缓冲区已经足够大了。)
#包括
#包括
#包括
#包括
#包括
#包括
#定义WS_大小10000000
uint8_t*工作空间;
空心cb(x264英寸,x264英寸,空心*不透明)
{
断言((nal->i_有效负载*3)/2+5+64
编辑:segfault在第一次调用
cb
调用x264\u nal\u encode
时发生。如果我切换到另一个预设,在第一次回调之前对更多帧进行编码,那么在第一次回调之前对x264\u encoder\u encode>进行了几次成功的调用,因此出现了segfault。在与x264开发人员讨论IRC后,我看到的行为似乎是,x264中的错误。传递给回调的x264_t*h
不正确。如果一个覆盖处理好的(从x264\u encoder\u open
获得的),事情就可以正常运行
我将x264 git commit 71ed44c7312438fac7c5c5301e45522e57127db4确定为第一个坏的。该bug被记录为
未来读者的更新:我相信这个问题已经在commit 544c61f082194728d0391fb280a6e138ba320a96中修复
#include <assert.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <x264.h>
#define WS_SIZE 10000000
uint8_t * workspace;
void cb(x264_t * h, x264_nal_t * nal, void * opaque)
{
assert((nal->i_payload*3)/2 + 5 + 64 < WS_SIZE);
x264_nal_encode(h, workspace, nal); // Segfault here.
// Removed: Process nal.
}
int main(int argc, char ** argv)
{
uint8_t * fake_frame = malloc(1280*720*3);
memset(fake_frame, 0, 1280*720*3);
workspace = malloc(WS_SIZE);
x264_param_t param;
int status = x264_param_default_preset(¶m, "ultrafast", "zerolatency");
assert(status == 0);
param.i_csp = X264_CSP_RGB;
param.i_width = 1280;
param.i_height = 720;
param.i_threads = 1;
param.i_lookahead_threads = 1;
param.i_frame_total = 0;
param.i_fps_num = 30;
param.i_fps_den = 1;
param.i_slice_max_size = 1024;
param.b_annexb = 1;
param.nalu_process = cb;
status = x264_param_apply_profile(¶m, "high444");
assert(status == 0);
x264_t * h = x264_encoder_open(¶m);
assert(h);
x264_picture_t pic;
status = x264_picture_alloc(&pic, param.i_csp, param.i_width, param.i_height);
assert(pic.img.i_plane == 1);
x264_picture_t pic_out;
x264_nal_t * nal; // Not used. We process NALs in cb.
int i_nal;
for (int i = 0; i < 100; ++i)
{
pic.i_pts = i;
pic.img.plane[0] = fake_frame;
status = x264_encoder_encode(h, &nal, &i_nal, &pic, &pic_out);
}
x264_encoder_close(h);
x264_picture_clean(&pic);
free(workspace);
free(fake_frame);
return 0;
}