Warning: file_get_contents(/data/phpspider/zhask/data//catemap/6/cplusplus/137.json): failed to open stream: No such file or directory in /data/phpspider/zhask/libs/function.php on line 167

Warning: Invalid argument supplied for foreach() in /data/phpspider/zhask/libs/tag.function.php on line 1116

Notice: Undefined index: in /data/phpspider/zhask/libs/function.php on line 180

Warning: array_chunk() expects parameter 1 to be array, null given in /data/phpspider/zhask/libs/function.php on line 181
C++ 你好,我的while循环不是';更新值后,t将响应其设置的条件。代码一直运行到最后_C++_Function_While Loop_Fstream_Iostream - Fatal编程技术网

C++ 你好,我的while循环不是';更新值后,t将响应其设置的条件。代码一直运行到最后

C++ 你好,我的while循环不是';更新值后,t将响应其设置的条件。代码一直运行到最后,c++,function,while-loop,fstream,iostream,C++,Function,While Loop,Fstream,Iostream,代码链接: 您好,值更新后,我的while循环将不响应其设置的条件。代码一直运行到最后。如果您运行代码,您将看到我所说的内容(事实上,这样做是必要的)。当参数的值更新时,该值会累计并更改。当我在代码末尾打印出它的值时,它实际上注册为在整个循环中应该分配给它的数字,但是循环在应该停止时没有做任何事情。基本上,我的问题可能是一个无限循环。唯一的计数器是循环末尾的“return 0;” 我的教授给出了具体的指示:制作一个刽子手游戏。这个游戏通常包括一个玩家猜一个秘密单词的字母。错误的猜测导致刽子手的照

代码链接:

您好,值更新后,我的while循环将不响应其设置的条件。代码一直运行到最后。如果您运行代码,您将看到我所说的内容(事实上,这样做是必要的)。当参数的值更新时,该值会累计并更改。当我在代码末尾打印出它的值时,它实际上注册为在整个循环中应该分配给它的数字,但是循环在应该停止时没有做任何事情。基本上,我的问题可能是一个无限循环。唯一的计数器是循环末尾的“return 0;”

我的教授给出了具体的指示:制作一个刽子手游戏。这个游戏通常包括一个玩家猜一个秘密单词的字母。错误的猜测导致刽子手的照片一次只能画一段。一旦有7个错误的猜测,刽子手的图片已经绘制出来,玩家猜输了游戏。在你的游戏中,16道选择题中的7道错误答案将导致游戏失败。 程序1将16个问题写入名为“infle.txt”的文件 程序2读取“infle.txt”并使用问题进行刽子手游戏

使用一个名为“is_hung”的布尔值返回函数。此函数接受一个名为“num_errors”的整数参数。使用“if else”语句测试此参数,以根据错误答案的数量确定屏幕上显示多少绞刑架

整个绞刑架可通过以下代码段显示:

{
cout << "\t \t \t" << " O " << endl;
cout << "\t \t \t" << "/|\\" << endl;
cout << "\t \t \t" << " | " << endl;
cout << "\t \t \t" << "/ \\" << endl;
cout << " YOU ARE HUNG" endl;
return false; 
}
{

cout存在大量浪费、重复的代码,这使得阅读和调试非常困难,并显著增加了出错的风险

通过使用更少的变量、更好的循环和一点算术,可以大大减少此代码,例如:

#包括
#包括
#包括
使用名称空间std;
布尔伊斯洪(国际);
int main()
{
字符串问题;
字符串回答;
字符串用户应答;
const string correct_answers=“BBCDADADBDABCABB”;
int num_right=0;
int num_错误=0;
ifstream阅读器(“infle.txt”);
对于(int i=0;i<16;++i)
{
getline(读者,问题);//从infie.txt获取行

cout-Wow,这是一大块很老的代码。你能把它精简成一段吗?这段代码似乎做了16次完全相同的事情。使用字符串向量和循环而不是手动枚举所有变量将大大改进代码。@churill数组要比旁注中的向量好,没有理由传递
power
变量为
函数,因为它从未被使用过。您应该减少代码,有很多重复-->使用循环您应该使用调试器并遍历循环,直到num errors达到7,然后查看结果happens@RemyLebeau是的,我想我知道你的意思,实际上数组似乎更适合这里。可能类似于
std::string question;std::array answers;std::string userAnswer;
然后循环16次并重用变量。
#include <stdio.h>
#include <iostream>
#include <string>
#include <fstream>

using namespace std;

bool is_hung(int, bool);

int main()
{
    string question1;
    string answer1;
    string answer2;
    string answer3;
    string answer4;
    string question2;
    string answer5;
    string answer6;
    string answer7;
    string answer8;
    string question3;
    string answer9;
    string answer10;
    string answer11;
    string answer12;
    string question4;
    string answer13;
    string answer14;
    string answer15;
    string answer16;
    string question5;
    string answer17;
    string answer18;
    string answer19;
    string answer20;
    string question6;
    string answer21;
    string answer22;
    string answer23;
    string answer24;
    string question7;
    string answer25;
    string answer26;
    string answer27;
    string answer28;
    string question8;
    string answer29;
    string answer30;
    string answer31;
    string answer32;

    ifstream reader;

    reader.open("infile.txt");

    int num_right = 0;
    int num_error = 0;
    bool power = true;
    cout << power << endl;
    string user_answer1 = "";
    string user_answer2 = "";
    string user_answer3 = "";
    string user_answer4 = "";
    string user_answer5 = "";
    string user_answer6 = "";
    string user_answer7 = "";
    string user_answer8 = "";

    while (power == true) {
        while (num_error < 7) //should stop the while loop when number of incorrect answers are equal to 7
        {
            //1
            getline(reader, question1); //get line from infile.txt
            getline(reader, answer1);
            getline(reader, answer2);
            getline(reader, answer3);
            getline(reader, answer4);
            cout << question1 << endl; //print out line from file
            cout << answer1 << endl;
            cout << answer2 << endl;
            cout << answer3 << endl;
            cout << answer4 << endl;
            cout << "Enter Answer: ";
            cin >> user_answer1; //have the user input answer
            if (user_answer1 == "B") //if statement to determine correct answer
            {
                cout << "correct" << endl;
                num_right++; //adds 1 to num_right
                cout << "" << endl;
            }
            else //if user_answer is not equal answer/wrong answer
            {
                cout << "incorrect" << endl;
                num_error++; //add 1 to num_error
                power = is_hung(num_error, power); //get function
            }
            //2
            getline(reader, question2);
            getline(reader, answer5);
            getline(reader, answer6);
            getline(reader, answer7);
            getline(reader, answer8);
            cout << question2 << endl;
            cout << answer5 << endl;
            cout << answer6 << endl;
            cout << answer7 << endl;
            cout << answer8 << endl;
            cout << "Enter Answer: ";
            cin >> user_answer2;
            if (user_answer2 == "B") {
                cout << "correct" << endl;
                num_right++;
                cout << "" << endl;
            }
            else {
                cout << "incorrect" << endl;
                num_error++;
                power = is_hung(num_error, power);
            }
            //3
            getline(reader, question3);
            getline(reader, answer9);
            getline(reader, answer10);
            getline(reader, answer11);
            getline(reader, answer12);
            cout << question3 << endl;
            cout << answer9 << endl;
            cout << answer10 << endl;
            cout << answer11 << endl;
            cout << answer12 << endl;
            cout << "Enter Answer: ";
            cin >> user_answer3;
            if (user_answer3 == "C") {
                cout << "correct" << endl;
                num_right++;
                cout << "" << endl;
            }
            else {
                cout << "incorrect" << endl;
                num_error++;
                power = is_hung(num_error, power);
            }
            //4
            getline(reader, question4);
            getline(reader, answer13);
            getline(reader, answer14);
            getline(reader, answer15);
            getline(reader, answer16);
            cout << question4 << endl;
            cout << answer13 << endl;
            cout << answer14 << endl;
            cout << answer15 << endl;
            cout << answer16 << endl;
            cout << "Enter Answer: ";
            cin >> user_answer4;
            if (user_answer4 == "D") {
                cout << "correct" << endl;
                num_right++;
                cout << "" << endl;
            }
            else {
                cout << "incorrect" << endl;
                num_error++;
                power = is_hung(num_error, power);
            }
            //5
            getline(reader, question5);
            getline(reader, answer17);
            getline(reader, answer18);
            getline(reader, answer19);
            getline(reader, answer20);
            cout << question5 << endl;
            cout << answer17 << endl;
            cout << answer18 << endl;
            cout << answer19 << endl;
            cout << answer20 << endl;
            cout << "Enter Answer: ";
            cin >> user_answer5;
            if (user_answer5 == "A") {
                cout << "correct" << endl;
                num_right++;
                cout << "" << endl;
            }
            else {
                cout << "incorrect" << endl;
                num_error++;
                power = is_hung(num_error, power);
            }
            //6
            getline(reader, question6);
            getline(reader, answer21);
            getline(reader, answer22);
            getline(reader, answer23);
            getline(reader, answer24);
            cout << question6 << endl;
            cout << answer21 << endl;
            cout << answer22 << endl;
            cout << answer23 << endl;
            cout << answer24 << endl;
            cout << "Enter Answer: ";
            cin >> user_answer6;
            if (user_answer6 == "D") {
                cout << "correct" << endl;
                num_right++;
                cout << "" << endl;
            }
            else {
                cout << "incorrect" << endl;
                num_error++;
                power = is_hung(num_error, power);
            }
            //7
            getline(reader, question7);
            getline(reader, answer25);
            getline(reader, answer26);
            getline(reader, answer27);
            getline(reader, answer28);
            cout << question7 << endl;
            cout << answer25 << endl;
            cout << answer26 << endl;
            cout << answer27 << endl;
            cout << answer28 << endl;
            cout << "Enter Answer: ";
            cin >> user_answer7;
            if (user_answer7 == "A") {
                cout << "correct" << endl;
                num_right++;
                cout << "" << endl;
            }
            else {
                cout << "incorrect" << endl;
                num_error++;
                power = is_hung(num_error, power);
            }
            cout << power << endl;
            //8
            getline(reader, question8);
            getline(reader, answer29);
            getline(reader, answer30);
            getline(reader, answer31);
            getline(reader, answer32);
            cout << question8 << endl;
            cout << answer29 << endl;
            cout << answer30 << endl;
            cout << answer31 << endl;
            cout << answer32 << endl;
            cout << "Enter Answer: ";
            cin >> user_answer8;
            if (user_answer8 == "D") {
                cout << "correct" << endl;
                num_right++;
                cout << "" << endl;
            }
            else {
                cout << "incorrect" << endl;
                num_error++;
                power = is_hung(num_error, power);
            }
            cout << "" << endl;
            if (num_error > 7) {
                cout << "You got " << num_right << " out of 8. You lose." << endl;
            }
            else if (num_error < 7) {
                cout << "You got " << num_right << " out of 8. You Win." << endl;
            }
            reader.close();
            return 0;
        }
    }
    reader.close();
    cout << "" << endl;
    if (num_error > 7) {
        cout << "You got " << num_right << " out of 16. You lose." << endl;
    }
    else if (num_error < 7) {
        cout << "You got " << num_right << " out of 16. You Win." << endl;
    }
    return 0;
}

bool is_hung(int num_errors2, bool power2)
{
    if (num_errors2 == 1) {
        cout << "\t \t \t"
             << " O " << endl;
        cout << "" << endl;
        power2 = true;
        return power2;
    }
    else if (num_errors2 == 2) {
        cout << "\t \t \t"
             << " O " << endl;
        cout << "\t \t \t"
             << "/" << endl;
        cout << "" << endl;
        power2 = true;
        return power2;
    }
    else if (num_errors2 == 3) {
        cout << "\t \t \t"
             << " O " << endl;
        cout << "\t \t \t"
             << "/ \\" << endl;
        cout << "" << endl;
        power2 = true;
        return power2;
    }
    else if (num_errors2 == 4) {
        cout << "\t \t \t"
             << " O " << endl;
        cout << "\t \t \t"
             << "/|\\" << endl;
        cout << "" << endl;
        power2 = true;
        return power2;
    }
    else if (num_errors2 == 5) {
        cout << "\t \t \t"
             << " O " << endl;
        cout << "\t \t \t"
             << "/|\\" << endl;
        cout << "\t \t \t"
             << " | " << endl;
        cout << "" << endl;
        power2 = true;
        return power2;
    }
    else if (num_errors2 == 6) {
        cout << "\t \t \t"
             << " O " << endl;
        cout << "\t \t \t"
             << "/|\\" << endl;
        cout << "\t \t \t"
             << " | " << endl;
        cout << "\t \t \t"
             << "/ " << endl;
        cout << "" << endl;
        power2 = true;
        return power2;
    }
    else if (num_errors2 == 7) {
        cout << "\t \t \t"
             << " O " << endl;
        cout << "\t \t \t"
             << "/|\\" << endl;
        cout << "\t \t \t"
             << " | " << endl;
        cout << "\t \t \t"
             << "/ \\" << endl;
        cout << " YOU ARE HUNG" << endl;
        cout << "" << endl;
        power2 = false;
        return power2;
    }
}