Excel组合生成器

我有一个代码，它根据8列的输入生成一个排列，并将这些列连接在一起。到目前为止效果很好，但我遇到了一个问题。当填充超过2行时，该选项有效。因此，如果A-H中的任何列在第10行中只有一个条目，它就会崩溃。所有8列中的行都用A、B、C填充，如果第8列只有A，那么它将崩溃

我也试过了

Set col1 = Range(Range("A10"), Range("A" & Rows.Count).End(xlUp))

而不是

Set col1 = Range("A10", Range("A10").End(xlDown)) 

但是还有一个类型不匹配错误

任何帮助都会很好。这是全部代码：

Sub combinations()

Dim out() As Variant
Dim f, g, h, i, j, k, l, m As Long

Dim col1 As Range
Dim col2 As Range
Dim col3 As Range
Dim col4 As Range
Dim col5 As Range
Dim col6 As Range
Dim col7 As Range
Dim col8 As Range
Dim out1 As Range

'Set col1 = Range("A10", Range("A10").End(xlDown))
Set col1 = Range(Range("A10"), Range("A" & Rows.Count).End(xlUp))
Set col2 = Range("B10", Range("B10").End(xlDown))
Set col3 = Range("C10", Range("C10").End(xlDown))
Set col4 = Range("D10", Range("D10").End(xlDown))
Set col5 = Range("E10", Range("E10").End(xlDown))
Set col6 = Range("F10", Range("F10").End(xlDown))
Set col7 = Range("G10", Range("G10").End(xlDown))
Set col8 = Range("H10", Range("H10").End(xlDown))

c1 = col1
c2 = col2
c3 = col3
c4 = col4
c5 = col5
c6 = col6
c7 = col7
c8 = col8

'initializes each column from column1-column8 as Range, sets the size of the range from row10 to last row

Set out1 = Range("M1", Range("T1").Offset(UBound(c1) * UBound(c2) * UBound(c3) * UBound(c4) * UBound(c5) * UBound(c6) * UBound(c7) * UBound(c8)))
out = out1

'creates a range for the output

f = 1
g = 1
h = 1
i = 1
j = 1
k = 1
l = 1
m = 1
n = 1

Do While f <= UBound(c1)

    Do While g <= UBound(c2)
        Do While h <= UBound(c3)
            Do While i <= UBound(c4)

    Do While j <= UBound(c5)
        Do While k <= UBound(c6)
            Do While l <= UBound(c7)
             Do While m <= UBound(c8)
            out(n, 1) = c1(f, 1)
            out(n, 2) = c2(g, 1)
            out(n, 3) = c3(h, 1)
            out(n, 4) = c4(i, 1)
            out(n, 5) = c1(j, 1)
            out(n, 6) = c2(k, 1)
            out(n, 7) = c3(l, 1)
            out(n, 8) = c4(m, 1)
            'goes down one column and grabs each cells value

            n = n + 1
            m = m + 1
        Loop
        m = 1
        l = l + 1
    Loop
    l = 1
    k = k + 1
Loop
k = 1
j = j + 1
 Loop
        j = 1
        i = i + 1
    Loop
    i = 1
    h = h + 1
Loop
h = 1
g = g + 1
Loop
g = 1
f = f + 1
Loop

'repeats process for all 8 columns

out1.Value = out

'places values in the output range "out1"


Dim LastRow As Long
  LastRow = Cells(Rows.Count, "M").End(xlUp).Row

  'Range("Z1:Z" & LastRow).Formula = "=M1 & "" | "" & N1 & "" | "" & O1 & "" | "" & P1 & "" | "" & Q1 & "" | "" & R1 & "" | "" & S1 & "" | "" & T1 "


  Range("Z1:Z" & LastRow).Formula = "=M1 & $F$3 & N1 & $F$3 & O1 & $F$3 & P1 & $F$3 & Q1 & $F$3 & R1 & $F$3 & S1 & $F$3 & T1 "


     'concatentates the cells from column M-T, seperated by the delimiter in cell F3


    Range("Z1").Select
    Range(Selection, Selection.End(xlDown)).Select
    Selection.Copy
    Range("A1").Select
    Sheets("Sheet2").Select
    Columns("F").ColumnWidth = 120
    Range("F2").Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False
    Range("A1").Select

    'Copies the concatenated output, pastes in sheet2 as values

End Sub

---

您有多个问题：

Set col1 = Range("A10", Range("A10").End(xlDown))
c1 = col1

如果col1只填充了第10行，则此序列将导致c1成为维度为1到1048567、1到1的变量数组

最好是：

Set col1 = Range("A10", Cells(Rows.Count, "A").End(xlUp))

但是，这样一来，一列中只填充了一个单元格，c1就不再是数组了

因此，一种解决方案，即维护大部分算法，是使用此序列设置列和变量数组：

    Dim c1, c2, c3, c4, c5, c6, c7, c8

Dim col1 As Range
Dim col2 As Range
Dim col3 As Range
Dim col4 As Range
Dim col5 As Range
Dim col6 As Range
Dim col7 As Range
Dim col8 As Range
Dim out1 As Range

'Set col1 = Range("A10", Range("A10").End(xlDown))
Set col1 = Range("A10", Cells(Rows.Count, "A").End(xlUp))
Set col2 = Range("B10", Cells(Rows.Count, "b").End(xlUp))
Set col3 = Range("C10", Cells(Rows.Count, "c").End(xlUp))
Set col4 = Range("D10", Cells(Rows.Count, "d").End(xlUp))
Set col5 = Range("E10", Cells(Rows.Count, "e").End(xlUp))
Set col6 = Range("F10", Cells(Rows.Count, "f").End(xlUp))
Set col7 = Range("G10", Cells(Rows.Count, "g").End(xlUp))
Set col8 = Range("H10", Cells(Rows.Count, "h").End(xlUp))



c1 = col1
    If Not IsArray(c1) Then
        ReDim c1(1, 1)
        c1(1, 1) = col1.Value
    End If
c2 = col2
    If Not IsArray(c2) Then
        ReDim c2(1, 1)
        c2(1, 1) = col1.Value
    End If
c3 = col3
    If Not IsArray(c3) Then
        ReDim c3(1, 1)
        c3(1, 1) = col1.Value
    End If
c4 = col4
    If Not IsArray(c4) Then
        ReDim c4(1, 1)
        c4(1, 1) = col1.Value
    End If
c5 = col5
    If Not IsArray(c5) Then
        ReDim c5(1, 1)
        c5(1, 1) = col1.Value
    End If
c6 = col6
    If Not IsArray(c6) Then
        ReDim c6(1, 1)
        c6(1, 1) = col1.Value
    End If
c7 = col7
    If Not IsArray(c7) Then
        ReDim c7(1, 1)
        c7(1, 1) = col1.Value
    End If
c8 = col8
    If Not IsArray(c8) Then
        ReDim c8(1, 1)
        c8(1, 1) = col1.Value
    End If    

---

最后，您应该在VB编辑器中设置该选项以要求变量声明。这将在任何新模块的开头显式地放置选项，并确保您不仅声明了本代码中未声明的所有变量，而且还将有助于避免输入错误。

崩溃是什么意思？如果它产生错误，错误消息是什么，发生在哪一行。我在您的场景中看到的一个问题是，如果将变量等同于单个单元格范围，则生成的变量将不是数组。因此，当您将其作为数组处理时，您将得到一个错误。您需要在代码中检查这一点。Set out1=RangeM1，RangeT1.OffsetUBoundc1*UBoundc2*UBoundc3*UBoundc4*UBoundc5*UBoundc6*UBoundc7*UBoundc8当8列中的任何一列只有一行被填充时，这一行会导致溢出错误。然后您会遇到一些问题。如果查看变量的大小，其中只有一个条目，并且使用xldown选择范围，将产生一个巨大的数组。查看“局部变量”窗口，您将看到我的意思非常感谢您澄清问题，我将解决方案应用于所有列，并声明c1-c8您是对的。我应该已经这么做了。但是，当只显示一行时，它仍然显示溢出错误filled@nkodb37当出现错误时，请检查所有c1…c8变量的维度。@nkodb37当我将解决方案应用于所有列时，如果只在一行或多列中填充了一行，则不会出现溢出错误。我将c1-c8声明为变体，并复制/粘贴，如果不是IsArrayc1，则vTemp=c1 ReDim c11到1，1到1 c11，对于所有列，1=vTemp End If。当您在“局部变量”窗口中看到该错误时，请检查所有c1…c8变量的维度。正如我所指出的，我无法重现这个问题。