C# 对象“iCrypt”可以被多次释放
我看到了关于这个问题的几个问题。例如: 但是我不太清楚我应该用我的代码做什么。我从代码分析中得到的警告是: 1> D:\My Programs\2017\PTSTools\PTSTools\PTSTools.cs81:警告 CA2202:Microsoft。用法:对象“iCrypt”的处置次数超过 一旦进入方法“ptsToolClass.Cryptstring,string,bool”。避 生成不应调用的System.ObjectDisposedException 对一个对象进行多次处置。:Lines:81 有关方法:C# 对象“iCrypt”可以被多次释放,c#,code-analysis,C#,Code Analysis,我看到了关于这个问题的几个问题。例如: 但是我不太清楚我应该用我的代码做什么。我从代码分析中得到的警告是: 1> D:\My Programs\2017\PTSTools\PTSTools\PTSTools.cs81:警告 CA2202:Microsoft。用法:对象“iCrypt”的处置次数超过 一旦进入方法“ptsToolClass.Cryptstring,string,bool”。避 生成不应调用的System.ObjectDisposedException 对一个对象进行多次处置。:Li
private string Crypt(string strData, string strPassword, bool bEncrypt)
{
byte[] u8Salt = new byte[] { ... };
PasswordDeriveBytes iPass = new PasswordDeriveBytes(strPassword, u8Salt);
Rijndael iAlg = Rijndael.Create();
iAlg.Key = iPass.GetBytes(32);
iAlg.IV = iPass.GetBytes(16);
ICryptoTransform iTrans = (bEncrypt) ? iAlg.CreateEncryptor() : iAlg.CreateDecryptor();
MemoryStream iMem = new MemoryStream();
CryptoStream iCrypt = new CryptoStream(iMem, iTrans, CryptoStreamMode.Write);
byte[] u8Data;
if (bEncrypt)
u8Data = Encoding.Unicode.GetBytes(strData);
else
u8Data = Convert.FromBase64String(strData);
try
{
iCrypt.Write(u8Data, 0, u8Data.Length);
iCrypt.Close();
if (bEncrypt)
return Convert.ToBase64String(iMem.ToArray());
else
return Encoding.Unicode.GetString(iMem.ToArray());
}
catch
{
return null;
}
finally
{
iCrypt.Close();
}
}
有人能解释一下为什么在最后一行代码中会出现这个警告吗
多谢各位
更新:
根据评论,我将其更改为:
private string Crypt(string strData, string strPassword, bool bEncrypt)
{
byte[] u8Salt = new byte[] { ... };
PasswordDeriveBytes iPass = new PasswordDeriveBytes(strPassword, u8Salt);
Rijndael iAlg = Rijndael.Create();
iAlg.Key = iPass.GetBytes(32);
iAlg.IV = iPass.GetBytes(16);
ICryptoTransform iTrans = (bEncrypt) ? iAlg.CreateEncryptor() : iAlg.CreateDecryptor();
MemoryStream iMem = new MemoryStream();
using (CryptoStream iCrypt = new CryptoStream(iMem, iTrans, CryptoStreamMode.Write))
{
byte[] u8Data;
if (bEncrypt)
u8Data = Encoding.Unicode.GetBytes(strData);
else
u8Data = Convert.FromBase64String(strData);
try
{
iCrypt.Write(u8Data, 0, u8Data.Length);
iCrypt.Close();
if (bEncrypt)
return Convert.ToBase64String(iMem.ToArray());
else
return Encoding.Unicode.GetString(iMem.ToArray());
}
catch
{
return null;
}
}
}
但我现在有以下警告:
1>D:\My Programs\2017\PTSTools\PTSTools\PTSTools.cs(77): warning CA2202: Microsoft.Usage : Object 'iCrypt' can be disposed more than once in method 'PTSToolsClass.Crypt(string, string, bool)'. To avoid generating a System.ObjectDisposedException you should not call Dispose more than one time on an object.: Lines: 77
1>D:\My Programs\2017\PTSTools\PTSTools\PTSTools.cs(77): warning CA2202: Microsoft.Usage : Object 'iMem' can be disposed more than once in method 'PTSToolsClass.Crypt(string, string, bool)'. To avoid generating a System.ObjectDisposedException you should not call Dispose more than one time on an object.: Lines: 77
它现在不喜欢捕捉块
更新:
理解:
private string Crypt(string strData, string strPassword, bool bEncrypt)
{
byte[] u8Salt = new byte[] { 0x26, 0x19, 0x81, 0x4E, 0xA0, 0x6D, 0x95, 0x34, 0x26, 0x75, 0x64, 0x05, 0xF6 };
PasswordDeriveBytes iPass = new PasswordDeriveBytes(strPassword, u8Salt);
Rijndael iAlg = Rijndael.Create();
iAlg.Key = iPass.GetBytes(32);
iAlg.IV = iPass.GetBytes(16);
ICryptoTransform iTrans = (bEncrypt) ? iAlg.CreateEncryptor() : iAlg.CreateDecryptor();
MemoryStream iMem = new MemoryStream();
using (CryptoStream iCrypt = new CryptoStream(iMem, iTrans, CryptoStreamMode.Write))
{
byte[] u8Data;
if (bEncrypt)
u8Data = Encoding.Unicode.GetBytes(strData);
else
u8Data = Convert.FromBase64String(strData);
try
{
iCrypt.Write(u8Data, 0, u8Data.Length);
if (bEncrypt)
return Convert.ToBase64String(iMem.ToArray());
else
return Encoding.Unicode.GetString(iMem.ToArray());
}
catch
{
return null;
}
}
}
您正在呼叫iCrypt.Close;两次,从try语句中删除调用,您就可以了。您正在调用iCrypt.Close;两次,从try语句中删除调用,您就会没事。代码分析中的消息很清楚。您的代码将关闭iCrypt两次。一次在try块中,一次在finally块中。移除线路iCrypt。关闭;在iCrypt.Write之间的try块中。。。如果。。。警告就会消失 更好的方法是使用块:
using (CryptoStream iCrypt = new CryptoStream(...)) {
.... // your code without the finally block
}
using将调用iCrypt.Close,无论是否在块内引发异常。代码分析中的消息是明确的。您的代码将关闭iCrypt两次。一次在try块中,一次在finally块中。移除线路iCrypt。关闭;在iCrypt.Write之间的try块中。。。如果。。。警告就会消失 更好的方法是使用块:
using (CryptoStream iCrypt = new CryptoStream(...)) {
.... // your code without the finally block
}
using将调用iCrypt.Close,无论是否在块内引发异常。,分析器会看到:
try
{
iCrypt.Close();
}
finally
{
iCrypt.Close();
}
然后它正确地推断出这些调用可以连续发生,从而导致在第二次调用中抛出ObjectDisposedException
因此:您不需要在try块中使用iCrypt.Close,因为无论是否发生异常,它都将在finally中关闭。,分析器会看到:
try
{
iCrypt.Close();
}
finally
{
iCrypt.Close();
}
然后它正确地推断出这些调用可以连续发生,从而导致在第二次调用中抛出ObjectDisposedException
因此:您不需要在try块中使用iCrypt.Close,因为无论是否发生异常,它都将在finally中关闭