C# 如何创建DataAccessLayer？

我正在.Net中创建一个数据库应用程序。我使用DataAccessLayer与数据库通信.net对象，但我不确定这个类是否正确，是否有人可以交叉检查它并纠正任何错误

namespace IDataaccess
{
    #region Collection Class

    public class SPParamCollection : List<SPParams>
    {

    }
    public class SPParamReturnCollection : List<SPParams>
    {

    }
    #endregion
    #region struct
    public struct SPParams
    {
        public string Name
        {
            get;
            set;
        }
        public object Value
        {
            get;
            set;
        }
        public ParameterDirection ParamDirection
        {
            get;
            set;
        }
        public SqlDbType Type
        {
            get;
            set;
        }
        public int Size
        {
            get;
            set;
        }
        public string TypeName
        {
            get;
            set;
        }
        // public string datatype;
    }
    #endregion
    /// <summary>
    /// Interface DataAccess Layer implimentation New version 
     /// </summary>

    public interface IDataAccess
    {
        DataTable getDataUsingSP(string spName);
        DataTable getDataUsingSP(string spName, SPParamCollection spParamCollection);
        DataSet getDataSetUsingSP(string spName);
        DataSet getDataSetUsingSP(string spName, SPParamCollection spParamCollection);
        SqlDataReader getDataReaderUsingSP(string spName);
        SqlDataReader getDataReaderUsingSP(string spName, SPParamCollection spParamCollection);
        int executeSP(string spName);
        int executeSP(string spName, SPParamCollection spParamCollection, bool addExtraParmas);
        int executeSP(string spName, SPParamCollection spParamCollection);
        DataTable getDataUsingSqlQuery(string strSqlQuery);
        int executeSqlQuery(string strSqlQuery);
        SPParamReturnCollection executeSPReturnParam(string spName, SPParamReturnCollection spParamReturnCollection);
        SPParamReturnCollection executeSPReturnParam(string spName, SPParamCollection spParamCollection, SPParamReturnCollection spParamReturnCollection);
        SPParamReturnCollection executeSPReturnParam(string spName, SPParamCollection spParamCollection, SPParamReturnCollection spParamReturnCollection, bool addExtraParmas);
        int executeSPReturnParam(string spName, SPParamCollection spParamCollection, ref SPParamReturnCollection spParamReturnCollection);
        object getScalarUsingSP(string spName);
        object getScalarUsingSP(string spName, SPParamCollection spParamCollection);
    }
}

using IDataaccess;
namespace Dataaccess
{
    /// <summary>
    /// Class DataAccess Layer implimentation New version 
    /// </summary>

    public class DataAccess : IDataaccess.IDataAccess
    {
        #region Public variables
        static string Strcon;
        DataSet dts = new DataSet();

        public DataAccess()
        {
            Strcon = sReadConnectionString();
        }
        private string sReadConnectionString()

        {
            try
            {
                //dts.ReadXml("C:\\cnn.config");
                //Strcon = dts.Tables[0].Rows[0][0].ToString();

                //System.Configuration.Configuration config = ConfigurationManager.OpenExeConfiguration(ConfigurationUserLevel.None);

                //Strcon = config.ConnectionStrings.ConnectionStrings["connectionString"].ConnectionString;

                // Add an Application Setting.




               //Strcon = "Data Source=192.168.50.103;Initial Catalog=erpDB;User ID=ipixerp1;Password=NogoXVc3";
             Strcon =  System.Configuration.ConfigurationManager.AppSettings["connection"];
                //Strcon = System.Configuration.ConfigurationSettings.AppSettings[0].ToString();
            }

            catch (Exception)
            {
            }
            return Strcon;
        }

        public SqlConnection connection;
        public SqlCommand cmd;
        public SqlDataAdapter adpt;
        public DataTable dt;
        public int intresult;
        public SqlDataReader sqdr;
        #endregion
        #region Public Methods
        public DataTable getDataUsingSP(string spName)
        {
            return getDataUsingSP(spName, null);
        }
        public DataTable getDataUsingSP(string spName, SPParamCollection spParamCollection)
        {
            try
            {
                using (connection = new SqlConnection(Strcon))
                {
                    connection.Open();
                    using (cmd = new SqlCommand(spName, connection))
                    {
                        int count, param = 0;
                        if (spParamCollection == null)
                        { param = -1; }
                        else
                        {
                            param = spParamCollection.Count;
                        }
                        for (count = 0; count < param; count++)
                        {
                            cmd.Parameters.AddWithValue(spParamCollection[count].Name, spParamCollection[count].Value);
                        }
                        cmd.CommandType = CommandType.StoredProcedure;
                        cmd.CommandTimeout = 60;
                        adpt = new SqlDataAdapter(cmd);
                        dt = new DataTable();
                        adpt.Fill(dt);
                        return (dt);
                    }
                }
            }
            finally
            {
                connection.Close();
            }

        }

        public DataSet getDataSetUsingSP(string spName)
        {
            return getDataSetUsingSP(spName, null);
        }
        public DataSet getDataSetUsingSP(string spName, SPParamCollection spParamCollection)
        {
            try
            {
                using (connection = new SqlConnection(Strcon))
                {
                    connection.Open();
                    using (cmd = new SqlCommand(spName, connection))
                    {
                        int count, param = 0;
                        if (spParamCollection == null)
                        {
                            param = -1;
                        }
                        else
                        {
                            param = spParamCollection.Count;
                        }
                        for (count = 0; count < param; count++)
                        {
                            cmd.Parameters.AddWithValue(spParamCollection[count].Name, spParamCollection[count].Value);
                        }
                        cmd.CommandType = CommandType.StoredProcedure;
                        cmd.CommandTimeout = 60;
                        adpt = new SqlDataAdapter(cmd);
                        DataSet ds = new DataSet();
                        adpt.Fill(ds);
                        return ds;
                    }
                }
            }
            finally
            {
                connection.Close();
            }

        }
        public SqlDataReader getDataReaderUsingSP(string spName)
        {
            return getDataReaderUsingSP(spName, null);
        }
        public SqlDataReader getDataReaderUsingSP(string spName, SPParamCollection spParamCollection)
        {

            try
            {
                using (connection = new SqlConnection(Strcon))
                {
                    connection.Open();
                    using (cmd = new SqlCommand(spName, connection))
                    {
                        int count, param = 0;
                        if (spParamCollection == null)
                        { param = -1; }
                        else
                        {
                            param = spParamCollection.Count;
                        }
                        for (count = 0; count < param; count++)
                        {
                            cmd.Parameters.AddWithValue(spParamCollection[count].Name, spParamCollection[count].Value);
                        }
                        cmd.CommandType = CommandType.StoredProcedure;
                        cmd.CommandTimeout = 60;
                        sqdr = cmd.ExecuteReader();

                        return (sqdr);
                    }
                }
            }
            finally
            {
                connection.Close();
            }
        }
        public int executeSP(string spName)
        {
            return executeSP(spName, null);
        }
        public int executeSP(string spName, SPParamCollection spParamCollection, bool addExtraParmas)
        {
            try
            {

                using (connection = new SqlConnection(Strcon))
                {
                    connection.Open();
                    using (cmd = new SqlCommand(spName, connection))
                    {
                        int count, param = 0;
                        if (spParamCollection == null)
                        { param = -1; }
                        else
                        {
                            param = spParamCollection.Count;
                        }
                        for (count = 0; count < param; count++)
                        {
                            SqlParameter par = new SqlParameter(spParamCollection[count].Name, spParamCollection[count].Value);
                            if (addExtraParmas)
                            {
                                par.TypeName = spParamCollection[count].TypeName;
                                par.SqlDbType = spParamCollection[count].Type;
                            }
                            cmd.Parameters.Add(par);
                        }
                        cmd.CommandType = CommandType.StoredProcedure;
                        cmd.CommandTimeout = 60;
                        return (cmd.ExecuteNonQuery());
                    }
                }
            }

            finally
            {
                connection.Close();
            }

        }
        public int executeSP(string spName, SPParamCollection spParamCollection)
        {

            return executeSP(spName, spParamCollection, false);

        }

        public DataTable getDataUsingSqlQuery(string strSqlQuery)
        {

            try
            {
                using (connection = new SqlConnection(Strcon))
                    connection.Open();
                {
                    using (cmd = new SqlCommand(strSqlQuery, connection))
                    {
                        cmd.CommandType = CommandType.Text;
                        cmd.CommandTimeout = 60;
                        adpt = new SqlDataAdapter(cmd);
                        dt = new DataTable();
                        adpt.Fill(dt);
                        return (dt);
                    }
                }
            }
            finally
            {
                connection.Close();
            }

        }
        public int executeSqlQuery(string strSqlQuery)
        {

            try
            {
                using (connection = new SqlConnection(Strcon))
                {
                    connection.Open();
                    using (cmd = new SqlCommand(strSqlQuery, connection))
                    {
                        cmd.CommandType = CommandType.Text;
                        cmd.CommandTimeout = 60;
                        intresult = cmd.ExecuteNonQuery();
                        return (intresult);
                    }
                }
            }
            finally
            {
                connection.Close();
            }

        }
        public SPParamReturnCollection executeSPReturnParam(string spName, SPParamReturnCollection spParamReturnCollection)
        {
            return executeSPReturnParam(spName, null, spParamReturnCollection);
        }
        public int executeSPReturnParam()
        {
            return 0;
        }

        public int executeSPReturnParam(string spName, SPParamCollection spParamCollection, ref SPParamReturnCollection spParamReturnCollection)
        {
            try
            {
                SPParamReturnCollection spParamReturned = new SPParamReturnCollection();
                using (connection = new SqlConnection(Strcon))
                {
                    connection.Open();
                    using (cmd = new SqlCommand(spName, connection))
                    {
                        int count, param = 0;
                        if (spParamCollection == null)
                        { param = -1; }
                        else
                        {
                            param = spParamCollection.Count;
                        }
                        for (count = 0; count < param; count++)
                        {
                            cmd.Parameters.AddWithValue(spParamCollection[count].Name, spParamCollection[count].Value);
                        }
                        cmd.CommandType = CommandType.StoredProcedure;
                        foreach (SPParams paramReturn in spParamReturnCollection)
                        {
                            SqlParameter _parmReturn = new SqlParameter(paramReturn.Name, paramReturn.Size);
                            _parmReturn.Direction = paramReturn.ParamDirection;
                            if (paramReturn.Size > 0) _parmReturn.Size = paramReturn.Size;
                            else _parmReturn.Size = 32;
                            _parmReturn.SqlDbType = paramReturn.Type;
                            cmd.Parameters.Add(_parmReturn);
                        }
                        cmd.CommandTimeout = 60;
                        intresult = cmd.ExecuteNonQuery();
                        connection.Close();

                        //for (int i = 0; i < spParamReturnCollection.Count; i++)
                        //{
                        //    spParamReturned.Add(new SPParams
                        //    {
                        //        Name = spParamReturnCollection[i].Name,
                        //        Value = cmd.Parameters[spParamReturnCollection[i].Name].Value
                        //    });

                        //}
                    }
                }
                return intresult;
            }
            finally
            {
                connection.Close();

            }
        }
        public SPParamReturnCollection executeSPReturnParam(string spName, SPParamCollection spParamCollection, SPParamReturnCollection spParamReturnCollection)
        {
            return executeSPReturnParam(spName, spParamCollection, spParamReturnCollection, false);
        }
        public SPParamReturnCollection executeSPReturnParam(string spName, SPParamCollection spParamCollection, SPParamReturnCollection spParamReturnCollection, bool addExtraParmas)
        {
            try
            {
                SPParamReturnCollection spParamReturned = new SPParamReturnCollection();
                using (connection = new SqlConnection(Strcon))
                {
                    connection.Open();
                    using (cmd = new SqlCommand(spName, connection))
                    {
                        int count, param = 0;
                        if (spParamCollection == null)
                        { param = -1; }
                        else
                        {
                            param = spParamCollection.Count;
                        }
                        for (count = 0; count < param; count++)
                        {
                            //cmd.Parameters.AddWithValue(spParamCollection[count].Name, spParamCollection[count].Value);
                            SqlParameter par = new SqlParameter(spParamCollection[count].Name, spParamCollection[count].Value);
                            if (addExtraParmas)
                            {
                                par.TypeName = spParamCollection[count].TypeName;
                                par.SqlDbType = spParamCollection[count].Type;
                            }
                            cmd.Parameters.Add(par);
                         }
                        cmd.CommandType = CommandType.StoredProcedure;
                        foreach (SPParams paramReturn in spParamReturnCollection)
                        {
                            SqlParameter _parmReturn = new SqlParameter(paramReturn.Name, paramReturn.Value);
                            _parmReturn.Direction = paramReturn.ParamDirection;
                            if (paramReturn.Size > 0) _parmReturn.Size = paramReturn.Size;
                            else _parmReturn.Size = 32;
                            _parmReturn.SqlDbType = paramReturn.Type;
                            cmd.Parameters.Add(_parmReturn);
                        }
                        cmd.CommandTimeout = 60;
                        cmd.ExecuteNonQuery();
                        connection.Close();

                        for (int i = 0; i < spParamReturnCollection.Count; i++)
                        {
                            spParamReturned.Add(new SPParams
                            {
                                Name = spParamReturnCollection[i].Name,
                                Value = cmd.Parameters[spParamReturnCollection[i].Name].Value

                            });

                        }
                    }
                }
                return spParamReturned;
            }
            catch (Exception ex)
            {
                return null;
            }
            finally
            {
                connection.Close();
            }
        }
        public object getScalarUsingSP(string spName)
        {
            return getScalarUsingSP(spName, null);
        }
        public object getScalarUsingSP(string spName, SPParamCollection spParamCollection)
        {
            try
            {
                using (connection = new SqlConnection(Strcon))
                {
                    connection.Open();
                    using (cmd = new SqlCommand(spName, connection))
                    {
                        int count, param = 0;
                        if (spParamCollection == null)
                        { param = -1; }
                        else
                        {
                            param = spParamCollection.Count;
                        }
                        for (count = 0; count < param; count++)
                        {
                            cmd.Parameters.AddWithValue(spParamCollection[count].Name, spParamCollection[count].Value);
                            cmd.CommandTimeout = 60;
                        }
                        cmd.CommandType = CommandType.StoredProcedure;
                        return cmd.ExecuteScalar();
                    }
                }
            }
            finally
            {
                connection.Close();
                cmd.Dispose();
            }
        }
        #endregion
    }
}

名称空间访问
{
#区域集合类
公共类集合：列表
{
}
公共类集合：列表
{
}
#端区
#区域结构
公共结构参数
{
公共字符串名
{
得到；
设置
}
公共对象价值
{
得到；
设置
}
公共参数方向参数方向
{
得到；
设置
}
公共SqlDbType类型
{
得到；
设置
}
公共整数大小
{
得到；
设置
}
公共字符串类型名
{
得到；
设置
}
//公共字符串数据类型；
}
#端区
/// 
///接口数据访问层实现新版本
/// 
公共接口IDataAccess
{
DataTable getDataUsingSP（字符串spName）；
DataTable getDataUsingSP（字符串spName、SPParamCollection、SPParamCollection）；
数据集getDataSetUsingSP（字符串spName）；
数据集getDataSetUsingSP（字符串spName、SPParamCollection、SPParamCollection）；
SqlDataReader getDataReaderUsingSP（字符串spName）；
SqlDataReader getDataReaderUsingSP（字符串spName，SPParamCollection，SPParamCollection）；
int executeSP（字符串spName）；
int executeSP（字符串spName、SPParamCollection、SPParamCollection、bool addExtraParmas）；
int executeSP（字符串spName，SPParamCollection，SPParamCollection）；
DataTable getDataUsingSqlQuery（字符串strSqlQuery）；
int executeSqlQuery（字符串strSqlQuery）；
SPParamReturnCollection executeSPReturnParam（字符串spName，SPParamReturnCollection SPParamReturnCollection）；
SPParamReturnCollection executeSPReturnParam（字符串spName、SPParamCollection SPParamCollection、SPParamReturnCollection SPParamReturnCollection）；
SPParamReturnCollection executeSPReturnParam（字符串spName、SPParamCollection SPParamCollection、SPParamReturnCollection SPParamReturnCollection、bool AddExtraParams）；
int executeSPReturnParam（字符串spName、SPParamCollection SPParamCollection、ref SPParamReturnCollection SPParamReturnCollection）；
对象getScalarUsingSP（字符串spName）；
对象getScalarAsingSP（字符串spName、SPParamCollection、SPParamCollection）；
}
}
使用IDataaccess；
命名空间数据访问
{
/// 
///类数据访问层实现新版本
/// 
公共类数据访问：IDataaccess.IDataaccess
{
#区域公共变量
静态串结构；
数据集dts=新数据集（）；
公共数据访问（）
{
Strcon=sReadConnectionString（）；
}
私有字符串sReadConnectionString（）
{
尝试
{
//ReadXml（“C:\\cnn.config”）；
//Strcon=dts.Tables[0]。行[0][0]。ToString（）；
//System.Configuration.Configuration config=ConfigurationManager.OpenExeConfiguration（ConfigurationUserLevel.None）；
//Strcon=config.connectionString.connectionString[“connectionString”].connectionString；
//添加应用程序设置。
//Strcon=“数据源=192.168.50.103；初始目录=erpDB；用户ID=ipixerp1；密码=NogoXVc3”；
Strcon=System.Configuration.ConfigurationManager.AppSettings[“connection”]；
//Strcon=System.Configuration.ConfigurationSettings.AppSettings[0].ToString（）；
}
捕获（例外）
{
}
返回Strcon；
}
公共连接；
公共SqlCommand命令cmd；
公共SqlDataAdapter adpt；
公共数据表dt；
公开结果；
公共SqlDataReader sqdr；
#端区
#区域公共方法
公共数据表getDataUsingSP（字符串spName）
{
返回getDataUsingSP（spName，null）；
}
公共数据表getDataUsingSP（字符串spName、SPParamCollection、SPParamCollection）
{
尝试
{
使用（连接=新的SqlConnection（Strcon））
{
connection.Open（）；
使用（cmd=newsqlcommand（spName，connection））
{
整数计数，参数=0；
if（spParamCollection==null）
{param=-1；}
其他的
{
param=spParamCollection.Count；
}
对于（计数=0；计数<参数；计数++）
{
cmd.Parameters.AddWithValue（spParamCollection[count].Name，spParamCollection[count].Value）；
}
cmd.CommandType=CommandType.storedProcess；
cmd.CommandTimeout=60；
adpt=新的SqlDataAdapter（cmd）；
dt=新数据表（）；
调整填充（dt）；
回报率（dt）；
}
}
}
最后
{
connection.Close（）；
}
}
公共数据集getDataSetUsingSP（字符串spName）
{
返回getDataSetUsingSP（spName，null）；
}
公共数据集getDataSetUsingSP（字符串spName、SPParamCollection、SPParamCollection）
{
尝试
{
使用（连接=新的SqlConnection（Strcon））
{
连接