如何更新逻辑以检查SQL查询状态,并基于c#中的返回true/false?
我不熟悉C#和SQL。 我的端点代码如下所示:如何更新逻辑以检查SQL查询状态,并基于c#中的返回true/false?,c#,sql,sql-server,asp.net-core,C#,Sql,Sql Server,Asp.net Core,我不熟悉C#和SQL。 我的端点代码如下所示: public IActionResult EndSession([Required(ErrorMessage = "Session Id is required.")]string sessionId) { DateTime startTime = DateTime.Now; try { string logText = LogFormatter.Format(
public IActionResult EndSession([Required(ErrorMessage = "Session Id is required.")]string sessionId)
{
DateTime startTime = DateTime.Now;
try
{
string logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", "Attempting to delete user session.");
logger.LogInfo(logText);
EndUserSession(sessionId);
logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", "Successfully deleted user session.");
logger.LogInfo(logText);
return Ok(true);
}
catch (Exception ex)
{
string logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", ex.ToString());
logger.LogError(logText, ex);
return StatusCode(Constants.InternalServerErrorCode, "Failed! Unable to delete user session. Please check logs for more details.");
}
}
public void EndUserSession(string sessionId)
{
using (SqlConnection connection = new SqlConnection(DataSourceHelper.ConnectionString))
{
try
{
using (SqlCommand command = new SqlCommand("EndUserSession", connection))
{
command.CommandType = CommandType.StoredProcedure;
command.CommandTimeout = Constants.SQL_COMMAND_TIMEOUT;
command.Parameters.AddWithValue("@SessionId", sessionId);
command.Parameters.AddWithValue("@SessionEndTime", DateTime.Now);
connection.Open();
command.ExecuteNonQuery();
}
}
catch (Exception)
{
throw;
}
}
}
var testSession = EndUserSession(sessionId);
if(testSession == true)
{
logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", "Successfully deleted user session.");
logger.LogInfo(logText);
return Ok(true);
}
else
{
logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", "SessionId not found, please try again.");
logger.LogInfo(logText);
return BadRequest(false);
}
我的数据访问层代码如下:
public IActionResult EndSession([Required(ErrorMessage = "Session Id is required.")]string sessionId)
{
DateTime startTime = DateTime.Now;
try
{
string logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", "Attempting to delete user session.");
logger.LogInfo(logText);
EndUserSession(sessionId);
logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", "Successfully deleted user session.");
logger.LogInfo(logText);
return Ok(true);
}
catch (Exception ex)
{
string logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", ex.ToString());
logger.LogError(logText, ex);
return StatusCode(Constants.InternalServerErrorCode, "Failed! Unable to delete user session. Please check logs for more details.");
}
}
public void EndUserSession(string sessionId)
{
using (SqlConnection connection = new SqlConnection(DataSourceHelper.ConnectionString))
{
try
{
using (SqlCommand command = new SqlCommand("EndUserSession", connection))
{
command.CommandType = CommandType.StoredProcedure;
command.CommandTimeout = Constants.SQL_COMMAND_TIMEOUT;
command.Parameters.AddWithValue("@SessionId", sessionId);
command.Parameters.AddWithValue("@SessionEndTime", DateTime.Now);
connection.Open();
command.ExecuteNonQuery();
}
}
catch (Exception)
{
throw;
}
}
}
var testSession = EndUserSession(sessionId);
if(testSession == true)
{
logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", "Successfully deleted user session.");
logger.LogInfo(logText);
return Ok(true);
}
else
{
logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", "SessionId not found, please try again.");
logger.LogInfo(logText);
return BadRequest(false);
}
存储过程:
IF OBJECT_ID('[dbo].[EndUserSession]') IS NOT NULL
DROP PROCEDURE [dbo].[EndUserSession]
GO
CREATE PROCEDURE [dbo].[EndUserSession]
@SessionId nvarchar(36),
@SessionEndTime datetime
WITH ENCRYPTION
AS
BEGIN
UPDATE [dbo].[USER_SESSION]
SET SESSION_END_DATETIME = @SessionEndTime
WHERE USER_SESSION_IID = @SessionId
END
GO
当数据库中不存在给定的sessionId时,应用程序停止并立即捕获错误,并从我调用此函数的端点抛出500个内部服务器错误代码
我要做的是更新逻辑,以便检查SQL查询状态,并根据EndUserSession函数返回的true/false,以及在出现故障或在User_会话表中找不到会话Id时记录的结果。实现这一点的最佳方法是什么?ExecuteOnQuery()返回受INSERT、UPDATE或DELETE语句影响的行数。因此,我将函数更改为return bool,并在数据访问中添加了以下逻辑:
int a = command.ExecuteNonQuery();
if (a == 0)
{
return false;
}
else
{
return true;
}
在我的端点中,我添加了一个if语句,如果函数返回true,它将返回一个200;如果它返回false,它将返回一个400错误的请求日志,说明找不到sessionId,因此没有更新任何内容。
情况如下:
public IActionResult EndSession([Required(ErrorMessage = "Session Id is required.")]string sessionId)
{
DateTime startTime = DateTime.Now;
try
{
string logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", "Attempting to delete user session.");
logger.LogInfo(logText);
EndUserSession(sessionId);
logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", "Successfully deleted user session.");
logger.LogInfo(logText);
return Ok(true);
}
catch (Exception ex)
{
string logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", ex.ToString());
logger.LogError(logText, ex);
return StatusCode(Constants.InternalServerErrorCode, "Failed! Unable to delete user session. Please check logs for more details.");
}
}
public void EndUserSession(string sessionId)
{
using (SqlConnection connection = new SqlConnection(DataSourceHelper.ConnectionString))
{
try
{
using (SqlCommand command = new SqlCommand("EndUserSession", connection))
{
command.CommandType = CommandType.StoredProcedure;
command.CommandTimeout = Constants.SQL_COMMAND_TIMEOUT;
command.Parameters.AddWithValue("@SessionId", sessionId);
command.Parameters.AddWithValue("@SessionEndTime", DateTime.Now);
connection.Open();
command.ExecuteNonQuery();
}
}
catch (Exception)
{
throw;
}
}
}
var testSession = EndUserSession(sessionId);
if(testSession == true)
{
logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", "Successfully deleted user session.");
logger.LogInfo(logText);
return Ok(true);
}
else
{
logText = LogFormatter.Format(
WebUtilities.GetUser((ClaimsIdentity)HttpContext.User.Identity),
startTime, DateTime.Now, Privilege.ViewIMUData,
"End Session", "SessionId not found, please try again.");
logger.LogInfo(logText);
return BadRequest(false);
}
你能分享一下存储过程的代码吗?@MartinStaufcik I添加了存储过程。存储过程要么更新行,要么不更新行,看起来没问题。您在catch块中捕获了什么异常?您可以尝试添加
catch(Exception ex)
而不是catch(Exception)
以查看异常详细信息。