Java Android-解析JSON数据显示重复结果

Java Android-解析JSON数据显示重复结果,java,android,json,networking,okhttp,Java,Android,Json,Networking,Okhttp,我正在尝试从以下站点下载数据 这是我下载数据的Android代码 公共类DownloadTask扩展了AsyncTask{ private List<Ingredients> tIngredients = new ArrayList<>(); private List<Steps> tSteps = new ArrayList<>(); String result; @Override protected String doInBackgrou

我正在尝试从以下站点下载数据

这是我下载数据的Android代码

公共类DownloadTask扩展了AsyncTask{

private List<Ingredients> tIngredients = new ArrayList<>();
private List<Steps> tSteps = new ArrayList<>();

String result;

@Override
protected String doInBackground(String... params) {
    result = "";
    OkHttpClient client = new OkHttpClient();
    Request request = new Request.Builder().url("https://d17h27t6h515a5.cloudfront.net/topher/2017/May/59121517_baking/baking.json").build();
    try {
        result = client.newCall(request).execute().body().string();
        Log.i("RESULT", result);
        JSONArray rootArray = new JSONArray(result);
        for (int i = 0; i < rootArray.length(); i++) {
            JSONObject tempObject = rootArray.getJSONObject(i);
            JSONArray ingredients = tempObject.getJSONArray("ingredients");
          for(int j = 0 ; j< ingredients.length(); j++) {
                JSONObject tempIngredient = ingredients.getJSONObject(j);
                Ingredients newIngredient = new Ingredients(tempIngredient.getString("quantity"),
                        tempIngredient.getString("measure"),
                        tempIngredient.getString("ingredient"));
                tIngredients.add(newIngredient);
                j++;
            }
            JSONArray steps = tempObject.getJSONArray("steps");
            for (int k = 0; k < steps.length(); k++) {
                JSONObject tempStep = steps.getJSONObject(k);
                Steps newStep = new Steps(tempStep.getString("id"), tempStep.getString("shortDescription"),
                        tempStep.getString("description"), tempStep.getString("videoURL"));
                tSteps.add(newStep);
            }
            Recipe newRecipe = new Recipe(tempObject.getString("id"), tempObject.getString("name"), tempObject.getString("servings"), tIngredients, tSteps);
            MainActivity.mRecipies.add(newRecipe);

        }
    } catch (Exception e) {
        Log.i("TAG", e.getMessage());
    }

    return null;
}

@Override
protected void onPostExecute(String s) {


    for (int i = 0; i < MainActivity.mRecipies.size(); i++) {

        Log.i("Recipie Number", String.valueOf(i));
        for (int j = 0; j < MainActivity.mRecipies.get(i).getIngredients().size(); j++) {
            Log.i("Ingre  - ", MainActivity.mRecipies.get(i).getIngredients().get(j).getIngredient());

        }
        MainActivity.myList.setAdapter(MainActivity.myAdapter);
        super.onPostExecute(s);
    }
}
然后我想可能是因为我没有清理两个ArrayList 这是我为这两个命令添加clear命令时的结果

Log.i("RESULT", result);
        JSONArray rootArray = new JSONArray(result);
        for (int i = 0; i < rootArray.length(); i++) {
            tIngredients.clear();
            tSteps.clear();
            JSONObject tempObject = rootArray.getJSONObject(i);
            JSONArray ingredients = tempObject.getJSONArray("ingredients");

请说明原因,提前感谢。

这两行需要进入您的循环:

private List<Ingredients> tIngredients = new ArrayList<>();
private List<Steps> tSteps = new ArrayList<>();
private List tingedints=new ArrayList();
private List tSteps=new ArrayList();

另外,第二个循环有一个额外的
j++
删除它。

在第二个循环的doinbackground方法中,您将j变量增加两倍,一个用于循环j++,然后是循环内j++。除非您想跳过成分,否则您应该删除循环内的j++

,您不需要字段

您需要每个配方的单独成分和步骤

你可能还想看看

JSONArray rootArray=新的JSONArray(结果);
//每种食谱
对于(int i=0;i
建议:

  • 改造
  • 格森
  • 在活动类中不使用静态变量

你为什么要使用AsyncTask来使用OkHTTP?我尝试过使用你的方法,但现在相同的数据重复了,第一步的成分重复了,剩下的部分重复了。你读过我答案中的链接了吗?它是否适用于你的代码?是的,我读过你的链接,它完全适用于我的代码,但我使用的是静态的,因为e更多依赖于mRecipies arraylist的活动。请您解释如何克服此问题。理想情况下,您可以将数据存储在持久性存储中,例如SQLite,您可以跨所有活动或片段对象查询。或者使用单例模式。或者这个新的ViewModel东西……关键是您的
配方
Component
类尤其不应该有静态值。如果有,那么,是的,所有对象都是重复的,因为这些对象的所有实例只有一个静态值。非常感谢,我一定会尝试单例模式
06-21 05:21:50.464 32625-32625/com.example.vamshi.baking I/Recipie Number: 0
06-21 05:21:50.464 32625-32625/com.example.vamshi.baking I/Ingre  -: Graham Cracker crumbs
06-21 05:21:50.464 32625-32625/com.example.vamshi.baking I/Ingre  -: granulated sugar
06-21 05:21:50.464 32625-32625/com.example.vamshi.baking I/Ingre  -: vanilla,divided
06-21 05:21:50.464 32625-32625/com.example.vamshi.baking I/Ingre  -: large whole eggs
06-21 05:21:50.464 32625-32625/com.example.vamshi.baking I/Ingre  -: heavy cream
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Recipie Number: 1
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: Graham Cracker crumbs
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: granulated sugar
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: vanilla,divided
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: large whole eggs
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: heavy cream
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Recipie Number: 2
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: Graham Cracker crumbs
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: granulated sugar
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: vanilla,divided
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: large whole eggs
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: heavy cream
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Recipie Number: 3
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: Graham Cracker crumbs
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: granulated sugar
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: vanilla,divided
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: large whole eggs
06-21 05:21:50.465 32625-32625/com.example.vamshi.baking I/Ingre  -: heavy cream
private List<Ingredients> tIngredients = new ArrayList<>();
private List<Steps> tSteps = new ArrayList<>();
    JSONArray rootArray = new JSONArray(result);
    // For each Recipe
    for (int i = 0; i < rootArray.length(); i++) {
        JSONObject tempObject = rootArray.getJSONObject(i);
        JSONArray jIngredients = tempObject.getJSONArray("ingredients");
        JSONArray jSteps = tempObject.getJSONArray("steps");

        // Get the ingredients
        List<Ingredients> ingredients = new ArrayList<>();
        for(int j = 0 ; j< jIngredients.length(); j++) {
            JSONObject tempIngredient = jIngredients.getJSONObject(j);
            Ingredients newIngredient = new Ingredients(tempIngredient.getString("quantity"),
                    tempIngredient.getString("measure"),
                    tempIngredient.getString("ingredient"));
            ingredients.add(newIngredient);
        }

        // Get the steps
        List<Steps> steps = new ArrayList<>();
        for (int j = 0; j < jSteps.length(); j++) {
            JSONObject tempStep = jSteps.getJSONObject(j);
            Steps newStep = new Steps(tempStep.getString("id"), tempStep.getString("shortDescription"),
                    tempStep.getString("description"), tempStep.getString("videoURL"));
            steps.add(newStep);
        }

        // Create the recipe
        Recipe newRecipe = new Recipe(tempObject.getString("id"), tempObject.getString("name"), tempObject.getString("servings"), ingredients, steps);
        MainActivity.mRecipies.add(newRecipe);
    }