Javascript 重构角代码

我是angular的新开发人员。我想做一些家庭作业来创建有角度的表格。我花了将近一周的时间做这件事，但我的老师对此并不满意。我试着学习一些网络教程，我认为这很好，但显然，我的代码质量很差（根据老师的说法）。我还有另一个问题，因为我的代码与IE8兼容，它必须与IE11或chrome兼容。但就目前而言，这并不是当务之急。我的首要任务是提高代码的质量。这是：

(function () {
'use strict';

 // @module UploadDoc Feature
 // @description Definition of 'UploadDoc' module

 // Main controller
uploadDocFeature.controller('client.features.uploadDoc.Controller', [
    '$scope',
    '$http',
    '$parse',
    '$translate',
    '$timeout',
    'client.features.common.DataService',
    'client.features.login.SessionService',
    '$modalInstance',
    function ($scope, $http, $parse, $translate, $timeout, dataService, session, $modalInstance,ezBus) {
        var vm = this;
        // Const
        $scope.docCategory = "pdm_legal_document";

        // Declare an object for all select input, since if you use ng model, it will set its own scope (a child scope of our page)
        $scope.selected  = {};
        $scope.dateErrors = [];
        $scope.doc_classes = [];
        $scope.doc_types = [];
        $scope.context_input = '';
        vm.mapContextClassType = {};

        // Define all functions
        $scope.resetValidate = function () {
            $scope.form_invalid_file_required_4ie = false;
            $scope.form_invalid_4ie = false;
            $scope.form_invalid_context = false;
            $scope.context_hasResult = undefined;
            $scope.context_selected = undefined;
            $scope.dateErrors = [];
            dataService.failed = false;
            dataService.errMsg = '';
        };

        $scope.initDropDownList = function () {

            dataService.initDDL_formatChannel().then(function (result) {
                if (!vm.loadFailed(dataService)){
                    $scope.doc_channels = result["loadChannels"];
                    $scope.doc_formats =  result["loadFormats"];
                }
            });
            vm.loadContextClassType();

        };

        vm.loadContextClassType = function(){
            dataService.initDocClassType("loadAllClassType").then(function (result) {
                if (!vm.loadFailed(dataService)){
                    vm.mapContextClassType = result["loadAllClassType"];
                }
            });
        };

        $scope.validateSelection = function(){
            if(!$scope.context_input){
                vm.reInitContext();
            }
        };

        $scope.$watch("context_input", function(newValue){
            if(!newValue || newValue == ''){
                vm.reInitContext();
            }
        });

        $scope.updateDDL_DocClass = function (contextSelected) {
            $scope.doc_classes = [];
            $scope.doc_types = [];
            if(!vm.mapContextClassType){
                vm.loadContextClassType();
            }
            if(vm.mapContextClassType){
                var mapClass2Type = vm.mapContextClassType[contextSelected];
                for(var oneClass in mapClass2Type) {
                    var oneOption = {
                        label: $translate.instant('i18nClass.' +oneClass),
                        value: oneClass
                    };
                    $scope.doc_classes.push(oneOption);
                }
            }
        };

        $scope.onSelectClass = function (contextSelected, classSelected) {
            $scope.doc_types = [];
            if(!vm.mapContextClassType){
                vm.loadContextClassType();
            }
            if(vm.mapContextClassType){
                var listType = vm.mapContextClassType[contextSelected][classSelected];
                for (var i = 0; i < listType.length; i++) {
                    var oneType = listType[i];
                    var oneOption = {
                        label: $translate.instant('i18nType.' +oneType),
                        value: oneType
                    };
                    $scope.doc_types.push(oneOption);
                }
            }
        };

        $scope.clear = function () {
            // Reset Form
            var ele = document.getElementById("uploadForm");
            if (!(ele === undefined) && ele != null) {
                ele.reset();
            }
            $scope.finished = false;
            $scope.failed = false;

            $scope.resetValidate();
        };

        $scope.cancel= function(){
            $modalInstance.dismiss('cancel');
        };

        vm.loadFailed = function (dataService) {
            if (dataService.failed) {
                $scope.failed = true;
                $scope.errMsg = dataService.errMsg;
                return true;
            }
            return false;
        };

        //-------------- Context Search Functions------------------------

        $scope.onSelectValue = function (item, model, label) {
            if (angular.isObject(item)) {
                $scope.context_name = item.context_name;
                $scope.context_id = item.context_id;

                $scope.context_selected = true;

                $scope.updateDDL_DocClass("pdm_" + $scope.context_name);
            }
        };

        /**
         *   typeahead-editable="false" -> ngModel is set only the value is selected from the typeahead list
         */
        $scope.checkContext = function () {
            if ($scope.context_hasResult && !$scope.context_selected) {
                //Search has result, but not selected
                $scope.form_invalid_context = true;
                return false;
            } else if ($scope.context_hasResult == false) {
                $scope.form_invalid_context = true;
                return false;
            }
            $scope.form_invalid_context = false;
            return true;
        };

        vm.reInitContext = function (){
            $scope.context_selected = false;
            $scope.selected.doc_class = '';
            $scope.selected.doc_type = '';
            $scope.doc_classes = [];
            $scope.doc_types = [];
        }


        /**
         * method for the auto suggestion in dropdownlist
         * @param inputValue
         * @returns {*}
         */
        $scope.doAutoSearch = function (inputValue) {
            vm.reInitContext();
            if (typeof inputValue !== 'undefined' && inputValue.length > 0) {
                var url = './srv/navbarSearchServlet';
                var dataObj = {
                    "context_id": inputValue,
                    "context_name":["pdm_person","pdm_root","pdm_business_partner"],
                    "token": session.getTicket()
                };

                var headers = {"headers": {"Content-Type": "application/json; charset=UTF-8"}};
                //the first method in the then is for success the second for error
                return $http.post(url, dataObj, headers).then(function (response) {
                    var arrayObjects = [];
                    //test the status
                    if (response.status === 200) {
                        var results = response.data;
                        //iterate on the object of the results list : object ={context_id:value,context_name:<person or root>}
                        angular.forEach(results, function (object) {
                            //translate the context_name
                            var i18nName = 'i18nNavbarSearch.' + object.context_name;
                            var valueTranslated = $translate.instant(i18nName);
                            //add the display value to the object returned
                            object.display = object.context_id + ' - ' + valueTranslated;
                            this.push(object);
                        }, arrayObjects);
                    }

                    $scope.context_hasResult = arrayObjects.length > 0;

                    return arrayObjects;
                }, function (response) {
                    alert('An error occurred during the process,try again. If the problem persist, contact support team.');
                    return {};
                });
            }
        };
        //-------------- End Context Search Functions------------------------

        //-------------- Submit Functions------------------------

        $scope.uploadDoc_submit4IE = function () {
            if (uploadDoc_formValidate()) {
                //Use more basic js to submit
                document.getElementById("uploadForm").submit();
            }
        };

        window.uploadDoc_formValidate = function () {
            var rt = true;
            if ($scope.form_invalid_context)
                rt = false;

            if($scope.dateErrors.length > 0) {
                rt = false;
            }

            if (!(window.isIE10UP === undefined) && !window.isIE10UP) {
                $scope.form_validation_msg_4ie = "";
                $scope.form_invalid_4ie = false;
                $scope.form_invalid_file_required_4ie = false;

                // Just for IE Check, other browser should support HTML5 'required' property
                if ($("#fileToUpload").val() == '') {
                    $scope.form_invalid_file_required_4ie = true;
                    rt = false;
                }
                if ($("#context").val() == '') {
                    $scope.form_invalid_4ie = true;
                    $scope.form_validation_msg_4ie = $scope.form_validation_msg_4ie + " " + $translate.instant('i18nUploadDoc.lbl_context');
                    rt = false;
                }
                if ($("#doc_class").val() == '') {
                    $scope.form_invalid_4ie = true;
                    $scope.form_validation_msg_4ie = $scope.form_validation_msg_4ie + " " + $translate.instant('i18nUploadDoc.lbl_docClass');
                    rt = false;
                }
                if ($("#doc_type").val() == '') {
                    $scope.form_invalid_4ie = true;
                    $scope.form_validation_msg_4ie = $scope.form_validation_msg_4ie + " " + $translate.instant('i18nUploadDoc.lbl_docType');
                    rt = false;
                }
            }

            if (rt) {
                // When validated, fetch real token, set the hidden input value for submit
                setHiddenInput('uploadForm','token', session.getTicket());
            }
            return rt;
        };


        window.uploadDoc_showResult = function () {
            var d = window.frames['uploadDoc_ResultFrame'].document;
            var resultStr = '';
            // IE Case
            if (!(window.isIE10UP === undefined) && !window.isIE10UP) {
                resultStr = $(d.body).text();
            }
            // Other browser case
            else if (d.getElementsByTagName('pre').length > 0 && d.getElementsByTagName('pre')[0].innerHTML != '') {
                resultStr = d.getElementsByTagName('pre')[0].innerHTML;
            }

            //Which means we have result
            if (resultStr != '') {
                var resultJson = angular.fromJson(resultStr);
                if (!(resultJson.KO === undefined)) {
                    //use $apply in asynchro call
                    $scope.$apply(function () {
                        $scope.failed = true;
                        $scope.errMsg = resultJson.KO;
                    }, 1000);
                } else {
                    //use $apply in asynchro call
                    $scope.$apply(function () {
                        $scope.finished = true;
                        $scope.resultMsg = 'i18nUploadDoc.msg_done';
                    }, 1000);

                }
            }
        };

        $scope.refreshGrid = function(){
            ezBus.broadcast('uploadDocFeature', 'gridFeature', 'RefreshGrid',$scope.finished);
            $scope.cancel();
        };

        //============== Init Feateure  ==============================
        $scope.resetValidate();
        $scope.initDropDownList();
        //============== End Init Feateure  ==============================
    }
]);

（函数（）{
"严格使用",；
//@module UploadDoc功能
//@UploadDoc模块的说明定义
//主控制器
uploadDocFeature.controller（'client.features.uploadDoc.controller'[
“$scope”，
“$http”，
“$parse”，
“$translate”，
“$timeout”，
'client.features.common.DataService'，
'client.features.login.SessionService'，
“$modalInstance”，
函数（$scope、$http、$parse、$translate、$timeout、dataService、session、$modalInstance、ezBus）{
var vm=这个；
//常数
$scope.docCategory=“pdm\u法律文件”；
//为所有select输入声明一个对象，因为如果您使用ng模型，它将设置自己的范围（我们页面的子范围）
$scope.selected={}；
$scope.dateErrors=[]；
$scope.doc_classes=[]；
$scope.doc_types=[]；
$scope.context_输入=“”；
vm.mapContextClassType={}；
//定义所有函数
$scope.resetValidate=函数（）{
$scope.form\u无效\u文件\u必需\u 4ie=false；
$scope.form_无效_4ie=false；
$scope.form_invalid_context=false；
$scope.context_hasResult=未定义；
$scope.context_selected=未定义；
$scope.dateErrors=[]；
dataService.failed=false；
dataService.errMsg=''；
};
$scope.initDropDownList=函数（）{
dataService.initDDL_formatChannel（）.then（函数（结果）{
如果（！vm.loadFailed（数据服务））{
$scope.doc_channels=结果[“加载通道”]；
$scope.doc_formats=结果[“加载格式”]；
}
});
vm.loadContextClassType（）；
};
vm.loadContextClassType=函数（）{
initDocClassType（“loadAllClassType”）。然后（函数（结果）{
如果（！vm.loadFailed（数据服务））{
vm.mapContextClassType=结果[“loadAllClassType”]；
}
});
};
$scope.validateSelection=函数（）{
if（！$scope.context\u输入）{
reInitContext（）；
}
};
$scope.$watch（“上下文输入”，函数（newValue）{
如果（！newValue | | newValue==“”）{
reInitContext（）；
}
});
$scope.updatedl_DocClass=函数（contextSelected）{
$scope.doc_classes=[]；
$scope.doc_types=[]；
如果（！vm.mapContextClassType）{
vm.loadContextClassType（）；
}
if（vm.mapContextClassType）{
var mapClass2Type=vm.mapContextClassType[contextSelected]；
for（mapClass2Type中的var oneClass）{
var oneOption={
标签：$translate.instant（'i18nClass.+oneClass'），
价值：一级
};
$scope.doc\u classes.push（一个选项）；
}
}
};
$scope.onSelectClass=函数（contextSelected，classSelected）{
$scope.doc_types=[]；
如果（！vm.mapContextClassType）{
vm.loadContextClassType（）；
}
if（vm.mapContextClassType）{
var listType=vm.mapContextClassType[contextSelected][classSelected]；
对于（var i=0；i仅设置从typeahead列表中选择的值
*/
$scope.checkContext=函数（）{
如果（$scope.context_hasResult&！$scope.context_选中）{
//搜索有结果，但未选中
$scope.form_invalid_context=true；
返回false；
}else if（$scope.context_hassresult==false）{
$scope.form_invalid_context=true；