Warning: file_get_contents(/data/phpspider/zhask/data//catemap/4/video/2.json): failed to open stream: No such file or directory in /data/phpspider/zhask/libs/function.php on line 167

Warning: Invalid argument supplied for foreach() in /data/phpspider/zhask/libs/tag.function.php on line 1116

Notice: Undefined index: in /data/phpspider/zhask/libs/function.php on line 180

Warning: array_chunk() expects parameter 1 to be array, null given in /data/phpspider/zhask/libs/function.php on line 181
Java 编码风格有问题吗_Java_Coding Style - Fatal编程技术网

Java 编码风格有问题吗

Java 编码风格有问题吗,java,coding-style,Java,Coding Style,我的编码风格有问题吗? 这是家庭作业,我试图提交,但它说我的风格是错误的:/ import java.util.Scanner; public class Groucho { String secret; public Groucho(String secret) { this.secret = secret; } public boolean saysSecret(String line) { if (line.indexOf(s

我的编码风格有问题吗? 这是家庭作业,我试图提交,但它说我的风格是错误的:/

import java.util.Scanner;
public class Groucho {
    String secret;
    public Groucho(String secret) {
        this.secret = secret;
    }
    public boolean saysSecret(String line) {
        if (line.indexOf(secret) != -1)
            return true;
        else 
            return false;
    }
    public static void main(String[] args) {
        Scanner in = new Scanner(System.in);
        System.out.println("Enter your secret word here: ");
        String a = in.nextLine();
        Groucho x = new Groucho(a);
        System.out.println("Please enter a sentence until you win the game");
        while (in.hasNextLine()) {
            String inp = in.nextLine();
            if (x.saysSecret(inp)) {
                System.out.println("You have won $100 for saying " + a);
                break;
            }
            else
                System.out.println("Try again");
        }
    }
}
这就是我的样式检查器所说的错误:

Request 1
File received, running checkstyle...
Starting audit...
Groucho.java:20: while child at indentation level 11 not at correct indentation, 12
Groucho.java:21: if at indentation level 11 not at correct indentation, 12
Groucho.java:22: if child at indentation level 15 not at correct indentation, 16
Groucho.java:22: method call child at indentation level 15 not at correct indentation, 16
Groucho.java:23: if child at indentation level 15 not at correct indentation, 16
Groucho.java:24: if rcurly at indentation level 11 not at correct indentation, 12
Groucho.java:25: else at indentation level 11 not at correct indentation, 12
Groucho.java:26: method call child at indentation level 15 not at correct indentation, 16
Audit done.

Done!

我喜欢做的一件事是换行,将相关代码分组成块或段落。我认为这使代码更容易阅读。至于您的错误消息,看起来您需要将行缩进一个空格?看起来它们比预期的要低一个级别。

所以显然我只需要在每个方法之间添加一个空格。愚蠢,但是是的。

明白了。。。。nnnnnnnnnnnnnn总是小事情。顺便说一句,你的风格看起来不错,继续保持下去!我有个问题。。。当我创建一个类和一个构造函数方法时。。。我必须首先初始化构造函数方法之外的变量,对吗?就像我在那里做的那样?串秘密;这是最佳做法。在构造函数外部初始化变量,然后在构造函数内部给变量一个值。有一点很好:将
sayscret()
更改为
返回行。indexOf(secret)>=0。谢谢:)我没想到这个问题更适合。有什么区别?