Python 列表附加无法正常工作
我的代码应该填充IP地址范围,这样就不会有重叠。我有一个以前的版本,它工作得很好,但我改变了它,使所有的过程自动化,减少浪费和资源密集 这是我当前的代码:Python 列表附加无法正常工作,python,list,python-3.x,dictionary,append,Python,List,Python 3.x,Dictionary,Append,我的代码应该填充IP地址范围,这样就不会有重叠。我有一个以前的版本,它工作得很好,但我改变了它,使所有的过程自动化,减少浪费和资源密集 这是我当前的代码: import ipaddress import csv from csv import DictReader, DictWriter import cProfile import pstats import operator import time start_time=time.strftime("%I:%M:%S %p", time.l
import ipaddress
import csv
from csv import DictReader, DictWriter
import cProfile
import pstats
import operator
import time
start_time=time.strftime("%I:%M:%S %p", time.localtime())
alphlst=[]
SubnetDic1=[]
global SubnetDic2
with open(r'C:\ExampleBefore.csv', newline='') as fin:
read = DictReader(fin)
for line in read:
alphlst.append(line)
def program():
print("started")
global alphlst
lst3=[]
global lst4
lst4=[]
global lst5
lst5=[]
endlist=[]
global SubnetDic1
SubnetDic1=[]
global SubnetDic2
SubnetDic2=[]
global SubOut1
SubOut1=[]
global SubOut2
SubOut2=[]
msklst=[]
global lst
lst=[]
print(alphlst)
print("^ alphlst")
for li in alphlst:
li['CIDR']=ipaddress.ip_network(li['CIDR'])
SubnetDic2.append(li)
if str(li['CIDR'].netmask) != '255.255.255.255':
SubnetDic1.append(li)
print("alph list clear")
alphlst=[]
print("after alph list clear")
print("Dic lists completed")
def Overlap(y, z):
global lst5
global lst
try:
if y['CIDR'].overlaps(z['CIDR']):
lst=list(y['CIDR'].address_exclude(z['CIDR'])) # List of subnets excluding line4 subnet
if len(lst) != 0:
print("not empty. {} is obsolete.".format(y['CIDR']))
lst5.append(str(y['CIDR']))
print(lst)
except ValueError:
return False
for line3 in SubnetDic1:
line3['CIDR']=ipaddress.ip_network(line3['CIDR']) # Convert IP ranges to ip network object
lst3.append(str(line3['CIDR']))
for line4 in SubnetDic2:
line4['CIDR']=ipaddress.ip_network(line4['CIDR']) # Convert IP ranges to ip network object
Overlap(line3, line4) # Tests for IP overlap
for val in lst:
if str(val) not in lst3:
if str(val) not in lst4:
subwr=line3
subwr['CIDR']=val # New range
subwr['IPStart']=val.network_address #New net address
subwr['IPStop']=val.broadcast_address #New broadcast address
SubOut1.append(subwr)
print("{} is line3".format(subwr))
print("{} is line3 tst".format(line3))
lst4.append(str(val))
print(SubOut1)
print("^ SubOut1")
print("Subnet part1 completed")
global lst7
lst7=[]
for line5 in SubnetDic2:
line5['CIDR']=ipaddress.ip_network(line5['CIDR']) # Convert IP ranges to ip network object
lst7.append(str(line5['CIDR']))
print("{} line5 end".format(line5))
if str(line5['CIDR']) not in lst5:
print("{} line5 aft".format(line5))
SubOut2.append(line5) # Write lines
print("Subnet part2 completed")
for line6 in SubOut2:
endlist.append(line6)
print("Subnet part3 completed")
for line7 in SubOut1:
endlist.append(line7)
print("Subnet part4 completed")
lst8=[]
for line10 in endlist:
line10['CIDR']=ipaddress.ip_network(line10['CIDR'])
line10['Mask']=line10['CIDR'].netmask
print("{} is line10 try".format(line10))
if str(line10['CIDR']) not in lst8:
msklst.append(line10)
lst8.append(str(line10['CIDR']))
print("{} is line10 append".format(line10))
srtlst=sorted(msklst, key=operator.itemgetter('Mask'), reverse=True)
for lip in srtlst:
alphlst.append(lip)
def all_true(items):
return all(x == "True" for x in items)
lstadd=[]
def in_lst():
global lst4
global SubnetDic2
global lstadd
global lst7
lstadd=[]
for l in lst4:
if l in lst7:
lstadd.append("True")
else:
lstadd.append("False")
print(lstadd)
print(lst4)
def chk_lst():
print("running chk_lst")
in_lst()
global lstadd
if all_true(lstadd):
return True
else:
return False
pass_start=time.strftime("%I:%M:%S %p", time.localtime())
cnt=1
cProfile.run('program()', 'prostats')
pass_end=time.strftime("%I:%M:%S %p", time.localtime())
p = pstats.Stats('prostats')
p.print_stats(0)
print("Pass {0}. Start: {1} End: {2}".format(cnt, pass_start, pass_end))
while chk_lst() is False:
pass_start2=time.strftime("%I:%M:%S %p", time.localtime())
cnt = cnt + 1
cProfile.run('program()', 'prostats2')
pass_end2=time.strftime("%I:%M:%S %p", time.localtime())
p = pstats.Stats('prostats2')
p.print_stats(0)
print("Pass {0}. Start: {1} End: {2}".format(cnt, pass_start2, pass_end2))
print("All Subnets Done")
with open(r'C:\ExampleBefore.csv', newline='') as fin7,\
open(r'C:\TstExample-sort1.csv', 'w', newline='') as fout5:
read7 = DictReader(fin7)
writenum6 = DictWriter(fout5, fieldnames=read7.fieldnames, extrasaction='ignore')
writenum6.writeheader()
global alphlst
for lime in alphlst:
writenum6.writerow(lime)
print("Write Complete")
我知道它很凌乱,我知道我现在正在做一些不必要的事情,那是因为我一直在努力让它工作,但还没有把它清理干净。例如,所有打印仅用于故障排除
这是输入文件的一个示例(但实际文件要大得多):
我发现问题出在代码的这一部分:
for line3 in SubnetDic1:
line3['CIDR']=ipaddress.ip_network(line3['CIDR']) # Convert IP ranges to ip network object
lst3.append(str(line3['CIDR']))
for line4 in SubnetDic2:
line4['CIDR']=ipaddress.ip_network(line4['CIDR']) # Convert IP ranges to ip network object
Overlap(line3, line4) # Tests for IP overlap
for val in lst:
if str(val) not in lst3:
if str(val) not in lst4:
subwr=line3
subwr['CIDR']=val # New range
subwr['IPStart']=val.network_address #New net address
subwr['IPStop']=val.broadcast_address #New broadcast address
SubOut1.append(subwr)
print("{} is line3".format(subwr))
print("{} is line3 tst".format(line3))
lst4.append(str(val))
print(SubOut1)
print("^ SubOut1")
基本上,附加到SubOut1
的值与应该的值不匹配。但是,它在两行中都打印它应该是的内容,print({}是line3.format(subwr))
和print({}是line3.tst.format(line3))
。请记住,我以前使用“line3”作为附加到列表的值,而不是subwr
,但这产生了相同的结果
这是一个示例,它为以下行打印内容:print(“{}是line3.format(subwr))
和print({}是line3.tst.format(line3))
:
这是列表“SubOut1”中的第一个过程(当它应该在上面的行和其他行中时):
以前工作的代码使用DictWriter写入行而不是附加到列表。它是“write.writerow(line3)”,而不是现在的SubOut1.append(subwr)
或类似的东西:SubOut1.append(line3)
有人能帮我弄清楚为什么它没有向SubOut1
添加正确的值,以及如何修复它吗
谢谢TL;博士
也就是说,这条线看起来很可疑:
subwr=line3
我认为应该是:
subwr=line3.copy()
问题在于Python中的对象始终是引用,因此如果执行以下操作:
SubOut1 = []
line3 = {}
line3[0] = "usefuldata"
subwr = line3
SubOut1.append(subwr)
line3[0] = "uselessdata"
print SubOut1
您将得到{0:“无用数据”}
。因为所有subwr
,line3
和SubOut1[0]
都是对同一对象的引用。如果修改此对象,您将能够在任何地方看到该更改
将赋值替换为subwr=line3.copy()
,您将得到预期的结果
部分离题注意:这与您不应该这样做来初始化列表的原因相同:
a = b = c = []
但你必须这样做:
a = []
b = []
c = []
这有很多代码需要通读——如果你把它删减一点,并尽量用你认为的问题更简洁(与通常的“请为这个问题提供上下文”相反),你可能会有更多的运气。你能提供一个简单的答案吗?这有很多代码需要涉过。“通过更清楚地确定问题发生的位置,您已经朝着解决问题迈出了重要的一步。突出问题起源的过程本身可以帮助您解决问题。您可以更仔细地查看您删除的部分,并在这样做的过程中发现问题。”好的,我现在将尝试这样做。
SubOut1 = []
line3 = {}
line3[0] = "usefuldata"
subwr = line3
SubOut1.append(subwr)
line3[0] = "uselessdata"
print SubOut1
a = b = c = []
a = []
b = []
c = []