C 尝试创建链接列表时出现分段错误
我目前第一次学习C语言,为了完成一项作业,我需要创建一个链表。我在过去没有遇到过简单的问题,但是函数抽象和指针传递似乎让我感到困惑,因为我无法完成这个任务。运行程序时,我一直收到分段错误。基本上,我从两个独立的文件中读取数据,然后填充列表。从那里我对数据做了其他修改,但在这个阶段,这是不相关的,因为我甚至不能从文件中加载数据。列表使用tm struct进行控制,tm struct从main传递到各个函数(&tm) 我一直在使用Valgrind和gdb进行尝试和诊断,但由于不熟悉调试,所以很难进行诊断。经过两天的反复试验,我觉得我缺少了一些至关重要的东西。以下是我的代码和错误消息:C 尝试创建链接列表时出现分段错误,c,C,我目前第一次学习C语言,为了完成一项作业,我需要创建一个链表。我在过去没有遇到过简单的问题,但是函数抽象和指针传递似乎让我感到困惑,因为我无法完成这个任务。运行程序时,我一直收到分段错误。基本上,我从两个独立的文件中读取数据,然后填充列表。从那里我对数据做了其他修改,但在这个阶段,这是不相关的,因为我甚至不能从文件中加载数据。列表使用tm struct进行控制,tm struct从main传递到各个函数(&tm) 我一直在使用Valgrind和gdb进行尝试和诊断,但由于不熟悉调试,所以很难进行
/* global type definitions */
typedef struct tm * tm_type_ptr;
typedef struct stock_list * stock_list_ptr;
typedef struct coin * coin_list_ptr;
typedef struct tm {
coin_list_ptr coins;
stock_list_ptr stock;
} tm_type;
/*coin structs*/
enum coin_types {
FIVE_CENTS=5,
TEN_CENTS=10,
TWENTY_CENTS=20,
FIFTY_CENTS=50,
ONE_DOLLAR=100,
TWO_DOLLARS=200
};
struct coin {
enum coin_types denomination;
unsigned count;
};
/* stock structs*/
struct stock_data
{
char ticket_name[TICKET_NAME_LEN+1];
char ticket_type;
char ticket_zone[TICKET_ZONE_LEN+1];
unsigned int ticket_price;
unsigned int stock_level;
};
typedef struct stock_node
{
struct stock_data * data;
struct stock_node * next_node;
} stock_node;
struct stock_list
{
stock_node * head_stock;
unsigned int num_stock_items;
};
然后使用以下函数填充结构:
BOOLEAN system_init(tm_type * tm)
{
tm->coins=malloc(sizeof(struct coin) * NUM_COINS);
tm->stock=malloc(sizeof(struct stock_list));
tm->stock->head_stock = malloc(sizeof(stock_node));
tm->stock->head_stock->data = malloc(sizeof (struct stock_data));
tm->coins->count = 0;
tm->stock->num_stock_items =0;
if (tm == NULL)
{
return FALSE;
}
else
{
return TRUE;
}
}
BOOLEAN load_data(tm_type * tm, char * stockfile, char * coinsfile)
{
FILE *stock_fp = fopen(stockfile, "r");
FILE *coins_fp = fopen(coinsfile, "r");
char *input= NULL, *token = NULL;
unsigned coin_type, amount;
/*stock variables*/
unsigned stock_count=0;
unsigned int ticket_price, stock_level;
char *ticket_name = NULL, ticket_type, *ticket_zone= NULL;
while(fgets(input, buffer_size, coins_fp) != NULL)
{
token= strtok(input, ",");
coin_type = strtol(token, NULL, 10);
if(token != NULL)
{
token= strtok(NULL, ",");
amount = strtol(token, NULL, 10);
}
if(!populate_coin_array(tm, coin_type, amount))
{
printf("OMG YOU SUCK!\n");
}
}
}
/*display_coin_array(tm); */
}
fclose(coins_fp);
free(input);
/*read stock file and populate stock structure */
if(fseek(stock_fp ,0, SEEK_END) == 0)
{
long buffer_size = ftell(stock_fp);
if(buffer_size == -1)
{
printf("Error! Exiting!\n");
return FALSE;
}
input = malloc(sizeof(char) * (buffer_size+1)); /*allocate buffer size plus one for ` '\0'*/
if(fseek(stock_fp,0,SEEK_SET) == 0)
{
while(fgets(input, buffer_size, stock_fp) != NULL)
{
ticket_name = strtok(input, ",");
ticket_type = *(strtok(NULL, ","));
ticket_zone = strtok(NULL, ",");
token = strtok(NULL, ",");
ticket_price = strtol(token, NULL, 10);
token = strtok(NULL,",");
stock_level = strtol(token, NULL, 10);
stock_count++;
if(!populate_stock_list(tm, ticket_name, ticket_type, ticket_zone,
ticket_price, stock_level, stock_count))
{
printf("ERROR!!!\n");
}
}
}
display_stock_list(tm, stock_count);
}
fclose(stock_fp);
free(input);
return TRUE;
}
BOOLEAN populate_coin_array(tm_type *tm, unsigned coin_type, unsigned amount)
{
struct coin single_coin;
struct coin *coin_array;
coin_array = malloc(sizeof(struct coin) * NUM_COINS);
single_coin = *(tm->coins);
single_coin.denomination = coin_type;
single_coin.count = amount;
*coin_array = single_coin;
tm->coins = coin_array;
return TRUE;
}
BOOLEAN populate_stock_list(tm_type *tm, char *ticket_name, char ticket_type,
char *ticket_zone, unsigned int ticket_price, unsigned int stock_level,
unsigned int stock_count)
{
tm_type temp_list;
struct stock_node *new_node;
temp_list = *tm;
new_node = malloc(sizeof(stock_node*));
if(new_node != NULL)
{
strcpy(new_node->data->ticket_name, ticket_name);
new_node->data->ticket_type = ticket_type;
strcpy(new_node->data->ticket_zone , ticket_zone);
new_node->data->ticket_price = ticket_price;
new_node->data->stock_level = stock_level;
new_node->next_node = temp_list.stock->head_stock;
temp_list.stock->head_stock = new_node;
temp_list.stock->num_stock_items = stock_count;
}
return TRUE;
}
很抱歉,我从许多.c和.h文件中获取了大量混乱的代码。我试着尽可能地减少,以便更容易进行故障排除
Valgrind给了我这个:
==16716== Use of uninitialised value of size 8
==16716== at 0x4C2BFFC: strcpy (in /usr/lib/valgrind/vgpreload_memcheck-amd64-
linux.so)
==16716== by 0x400D37: populate_stock_list (tm_stock.c:37)
==16716== by 0x40128F: load_data (tm_utility.c:129)
==16716== by 0x40098F: main (tm.c:57)
==16716==
==16716== Invalid write of size 1
==16716== at 0x4C2BFFC: strcpy (in /usr/lib/valgrind/vgpreload_memcheck-amd64-
linux.so)
==16716== by 0x400D37: populate_stock_list (tm_stock.c:37)
==16716== by 0x40128F: load_data (tm_utility.c:129)
==16716== by 0x40098F: main (tm.c:57)
==16716== Address 0x0 is not stack'd, malloc'd or (recently) free'd
==16716==
==16716==
==16716== Process terminating with default action of signal 11 (SIGSEGV)
==16716== Access not within mapped region at address 0x0
==16716== at 0x4C2BFFC: strcpy (in /usr/lib/valgrind/vgpreload_memcheck-amd64-
linux.so)
==16716== by 0x400D37: populate_stock_list (tm_stock.c:37)
==16716== by 0x40128F: load_data (tm_utility.c:129)
==16716== by 0x40098F: main (tm.c:57)
你能帮我指出正确的方向吗?我不希望任何人给我答案,我只是想知道为什么会发生这种情况
谢谢 在使用它之前,您需要为
新节点->数据
分配struct stock\u data*
。
另外,在malloc()
中,传递为其指针大小分配的结构的大小
更新将是
//--------------------------------v no * here
new_node = malloc(sizeof(*new_node));
if(new_node != NULL)
{
new_node->data = malloc(sizeof(*(new_node->data)));
...
//your code
谢谢Rohan,就这样!我在挠头,想我没有分配内存的地方。我也明白Valgrind要把我送到哪里,我只是觉得我没有更早地分配内存。再次感谢你,我真的很感激!我相信“指针的大小”是一个错误的理解。。。它应该是
new\u node=malloc(sizeof*new\u node)代码>,它消除了键入类型名称的需要,并将分配的大小“锁定”为实际表达式的大小,该表达式可以轻松验证为正确的大小,即接收malloc()
返回值的指针。