Optimization 改进SharePoint代码
我必须在SharePoint中做一个计时器,查看各种列表和工作流实例,是否应该改进代码 我有很多如果,foreach,我不知道我是否应该改变 代码如下:Optimization 改进SharePoint代码,optimization,sharepoint-2010,Optimization,Sharepoint 2010,我必须在SharePoint中做一个计时器,查看各种列表和工作流实例,是否应该改进代码 我有很多如果,foreach,我不知道我是否应该改变 代码如下: if (DateTime.Now.DayOfWeek == DayOfWeek.Friday || DateTime.Now.DayOfWeek == DayOfWeek.Tuesday) { using (S
if (DateTime.Now.DayOfWeek == DayOfWeek.Friday || DateTime.Now.DayOfWeek == DayOfWeek.Tuesday)
{
using (SPSite site = new SPSite(ConfigManagerHelper.GetSetting("siteUrl")))
{
using (SPWeb web = site.OpenWeb())
{
SPList list = web.Lists[ConfigManagerHelper.GetSetting("listName")];
SPListItemCollection items = list.Items;
foreach (SPListItem item in items)
{
string tipo = item.ContentType.Name;
if (tipo != CMIHelper.IndicadorEstrategico && tipo != CMIHelper.ObjetivoEstrategico && tipo != CMIHelper.ObjetivoOperativo)
{
continue;
}
if (tipo.Equals(CMIHelper.ObjetivoEstrategico))
{
foreach (SPWorkflow wf in item.Workflows)
{
if (wf.InternalState == SPWorkflowState.Running)
{
//Indicadores
if (wf.ParentAssociation.BaseTemplate.Name == "WFCuadroMandos")
{
foreach (SPListItem indAux in web.Lists["IndicadoresAux"].Items)
{
if (wf.InstanceId.ToString().Equals(indAux["APV_PE_WorkflowIdAux"].ToString()))
{
}
}
}
//Objetivos Estratégicos
if (wf.ParentAssociation.BaseTemplate.Name == "WFCuadroMandosObjEstr")
{
}
}
}
}
}
}
}
}
谢谢,首先,比ifs更好的是swich case,接下来您的一些代码可以对未列出的内容进行操作,我们添加 试一试 你曾经用得很好
foreach (SPListItem item in list.Items)
并检查一些空值:
并改变它:
提波!=CMIHelper.indicatorestategico&&tipo!=CMIHelper.objetivoestategico&tipo!=CMIHelper.ObjetivoOperativo
走进林克
foreach (SPListItem item in list.Items)